[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#505750: marked as done (d-i: allow user to return to syslinux VESA menu from help screens)

Your message dated Thu, 22 Jan 2009 23:47:25 +0000
with message-id <E1LQ9Gf-00050T-5c@ries.debian.org>
and subject line Bug#505750: fixed in debian-installer 20090122
has caused the Debian Bug report #505750,
regarding d-i: allow user to return to syslinux VESA menu from help screens
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
505750: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505750
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: debian-installer
Version: 20081029
Severity: wishlist
Tags: patch

The attached patch makes it possible to return to the graphical syslinux 
boot menu after viewing the help screens by typing 'menu'.

Patch is based on research done by Franklin Piat as discussed on #d-boot a 
few days ago.

There is one thing missing in the patch and that is some indication to the 
user that the option exists. I see three options:
1) add a help text when the user selects Help in the graphical menu
   I had a look at that but could not make it work: it kept overwriting
   some existing lines in the menu. Main problem is that because the menu
   starts so low there are not many lines available. If someone
   (Franklin maybe?) wants to give this another shot that would be great.
2) add a line in the F1 or other help screen
   The F1 screen is already pretty full (especially for I suspect sercon!)
   and I could not really find anywhere else that's logical. Additional
   problem is that not all installation methods use the vesamenu, so that
   would need to be made clear, or the text made variable.
   IMO we should think about restructuring the help screens for Squeeze.
3) mention it in the boot prompt line
   Even less space and same problem that its not valid for all methods.

As this is quite a nice usability improvement (even without the hint), I 
suggest including it for RC2, but will wait with commit for approval from 
RM. If accepted, I can probably manage to at least get it documented in 
the installation guide.


diff --git a/installer/build/boot/x86/exithelp.cfg b/installer/build/boot/x86/exithelp.cfg
new file mode 100644
index 0000000..6d9579a
--- /dev/null
+++ b/installer/build/boot/x86/exithelp.cfg
@@ -0,0 +1,3 @@
+label menu
+	kernel ${SYSDIR}vesamenu.c32
+	config ${SYSDIR}${SYSLINUX_CFG}
diff --git a/installer/build/boot/x86/prompt.cfg b/installer/build/boot/x86/prompt.cfg
index cd2957d..5ee6b27 100644
--- a/installer/build/boot/x86/prompt.cfg
+++ b/installer/build/boot/x86/prompt.cfg
@@ -2,6 +2,7 @@ prompt 1
 display ${SYSDIR}f1.txt
 timeout 0
 include ${SYSDIR}menu.cfg
+include ${SYSDIR}exithelp.cfg
 
 f1 ${SYSDIR}f1.txt
 f2 ${SYSDIR}f2.txt
diff --git a/installer/build/config/x86.cfg b/installer/build/config/x86.cfg
index 39a52f6..75bdd5c 100644
--- a/installer/build/config/x86.cfg
+++ b/installer/build/config/x86.cfg
@@ -72,6 +72,7 @@ endif
 				VIDEO_MODE $(VIDEO_MODE) \
 				VIDEO_MODE_GTK $(VIDEO_MODE_GTK) \
 				BEEP "$$beep" \
+				SYSLINUX_CFG syslinux.cfg \
 			| todos | mcopy -i$(TEMP_BOOT) - ::$$outfile; \
 		fi; \
 	)
@@ -169,6 +170,7 @@ arch_cd_info_dir:
 			VIDEO_MODE $(VIDEO_MODE) \
 			VIDEO_MODE_GTK $(VIDEO_MODE_GTK) \
 			BEEP "$$beep" \
+			SYSLINUX_CFG isolinux.cfg \
 		> $(TEMP_CD_INFO_DIR)/$$outfile; \
 	)
 
@@ -228,6 +230,7 @@ arch_miniiso:
 			VIDEO_MODE $(VIDEO_MODE) \
 			VIDEO_MODE_GTK $(VIDEO_MODE_GTK) \
 			BEEP "$$beep" \
+			SYSLINUX_CFG isolinux.cfg \
 		| todos > $(TEMP_CD_TREE)/$$outfile; \
 	)
 	
@@ -282,6 +285,7 @@ arch_netboot_dir:
 			INITRD $(NETBOOT_PATH)/initrd.gz \
 			VIDEO_MODE $(VIDEO_MODE) \
 			BEEP "$$beep" \
+			SYSLINUX_CFG syslinux.cfg \
 		> $$outfile; \
 	)

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---
--- Begin Message --- 
Source: debian-installer
Source-Version: 20090122

We believe that the bug you reported is fixed in the latest version of
debian-installer, which is due to be installed in the Debian FTP archive:

debian-installer-images_20090122_amd64.tar.gz byhand
debian-installer_20090122.dsc
  to pool/main/d/debian-installer/debian-installer_20090122.dsc
debian-installer_20090122.tar.gz
  to pool/main/d/debian-installer/debian-installer_20090122.tar.gz
debian-installer_20090122_amd64.deb
  to pool/main/d/debian-installer/debian-installer_20090122_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 505750@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Otavio Salvador <otavio@ossystems.com.br> (supplier of updated debian-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 22 Jan 2009 21:02:28 -0200
Source: debian-installer
Binary: debian-installer
Architecture: source amd64
Version: 20090122
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Otavio Salvador <otavio@ossystems.com.br>
Description: 
 debian-installer - Debian installer
Closes: 505750 505789 510015
Changes: 
 debian-installer (20090122) unstable; urgency=low
 .
   [ Martin Michlmayr ]
   * Fix off-by-one: the QNAP initrd should be padded to exactly 4 MB,
     not 4 MB - 1 byte.
 .
   [ Otavio Salvador ]
   * Add pata-modules on cdrom images (i386 and amd64) to enable support
     for Marvell controllers and others.
 .
   [ Frans Pop ]
   * Update minimum memory/diskspace requirements in x86 syslinux help
     screens. New values are the same as in the Installation Guide.
 .
   [ Samuel Thibault ]
   * Add uinput-modules to cdrom, netboot and hd-media images (amd64, alpha,
     i386, ppc64, ia64 and powerpc) to improve brltty device support.
 .
   [ Otavio Salvador ]
   * Apply patch from Jurij Smakov to add usb-storage to cdrom and netboot
     images (sparc) to allow firmware to be loaded from a usb devices.
     Closes: #505789.
 .
   [ Frans Pop ]
   * Add option in syslinux configuration to return to graphical boot menu
     from the help screens. Based on research done by Franklin Piat.
     Closes: #505750.
   * Rename syslinux adamd*.cfg files to amdad*.cfg.
   * Rename syslinux *text.cfg files to *txt.cfg. This is needed because
     adamdtext.cfg is one character too long which means it was never actually
     included in the menu for multi-arch images.
 .
   [ Franklin Piat ]
   * Add help text for help option in graphical syslinux boot menu to indicate
     how to return to the menu from the help screens.
     The new configuration also improves editing the command line from the
     graphical syslinux menu if it flows over into a second line.
 .
   [ Frans Pop ]
   * Add ext2-modules to hd-media images for i386, amd64 and powerpc.
     Closes: #510015.
   * Update copyright to 2009.
Checksums-Sha1: 
 6eeeb88302cc22ace8fa082c7646365836992bd8 2419 debian-installer_20090122.dsc
 9a99a21831be75076885afbba1fff63c5c2ee6db 2766127 debian-installer_20090122.tar.gz
 caed0b2ddfea007947d15444130d67cf096a811f 1516394 debian-installer_20090122_amd64.deb
 6bd5fc1edcefdd7ed369d0c7efab550c5b2d54e3 136671749 debian-installer-images_20090122_amd64.tar.gz
Checksums-Sha256: 
 3d10a4492295e534470cbcc8b0591ddf64cf52a469e1e86c4f7367c0672df376 2419 debian-installer_20090122.dsc
 6a9ec76f6f4a18f164f736ac65a0aa9493f826ef2162a1ed7624436ed5fb82d6 2766127 debian-installer_20090122.tar.gz
 5611476747dff0758ab170952cc126e15a01147194b57ba95b1d805a9c838ed6 1516394 debian-installer_20090122_amd64.deb
 5b158f12f7fde163731b919e5268ca0e2e26fd7dd46c773485aac063dabda07f 136671749 debian-installer-images_20090122_amd64.tar.gz
Files: 
 70d83f4eccc5e114f9812c2bdc1b0c3f 2419 devel optional debian-installer_20090122.dsc
 b174ee8a050840ac3bd12e6646ecb1b4 2766127 devel optional debian-installer_20090122.tar.gz
 382617783528cc86cc470e30c347774a 1516394 devel optional debian-installer_20090122_amd64.deb
 eb74732260f07410bb3a2524ca123f98 136671749 raw-installer - debian-installer-images_20090122_amd64.tar.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkl4/ZQACgkQLqiZQEml+FUwaQCgl0MP9IHbOJ3mTL20xc0mk3Hj
Qz4An29vNgjQ4twAQqVCV89nb1M1NLDP
=pPPa
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: