Re: [PATCH] allow setting of an specific script to be used by debootstrap
Frans Pop <elendil@planet.nl> writes:
> On Saturday 01 March 2008, Otavio Salvador wrote:
>> +# Check if a specific script should be used
>> +db_get base-installer/debootstrap_script
>> +DEBOOTSTRAP_SCRIPT="$RET" || true
>
> What's the point of the || true here?
>
> IMO the patch should test that the script exists and, if not, log the fact
> and either fail or unset the variable (maybe unless debootstrap itself
> already handles that case?).
debootstrap fails if the script isn't available however I think it's a
great improvement to log it properly if it doesn't exist. I'll make
this change.
>> + * Add facility to use a specific script by preseeding
>> + base-installer/script. That's a very interesting feature for Custom
>> + Debian Distributions and derivatives.
>
> The last sentence is a rather empty comment and should IMO be omitted.
Right. I will remove it, no problem.
--
O T A V I O S A L V A D O R
---------------------------------------------
E-mail: otavio@debian.org UIN: 5906116
GNU/Linux User: 239058 GPG ID: 49A5F855
Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
you the whole house."
Reply to: