[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#449292: marked as done (clock-setup: finish-install script is confusing and possibly broken)

Your message dated Mon, 07 Jan 2008 23:02:02 +0000
with message-id <E1JC0yo-0008Bj-61@ries.debian.org>
and subject line Bug#449292: fixed in clock-setup 0.93
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: clock-setup
Version: 0.93

After the last few (not yet uploaded) commits, part of the finish-install
script looks like this:

> # This may not be necessary; hwclock can do direct IO if
> # the rtc module is not loaded.
> log-output -t hw-detect modprobe -v rtc || log "rtc module not loaded"
> log-output -t hw-detect modprobe -v rtc-dev || log "rtc-dev module not loaded"
> update-dev

> machine=$(grep "^Hardware" /proc/cpuinfo | sed 's/Hardware\s*:\s*//')
> case "$machine" in
>         "Linksys NSLU2")
>                 # The nslu2 needs a special driver for the hardware
>                 # clock.
>                 update-dev

The comment and update-dev statement should no longer be needed here.

>                 # This driver creates a rtc0 device, so symlink.
>                 # XXX This won't be needed once a new udev that handles the
>                 # symlink gets into Debian.
>                 if [ -e /dev/rtc0 ]; then
>                         ln -sf rtc0 /dev/rtc
>                 fi

If rtc-dev is now a generic driver, shouldn't this symlink be created in
all cases (or at least in all cases where rtc-dev was loaded successfully),
and not just for NSLU?

>         ;;
> esac

What happens if both drivers get loaded? Can that happen? Shouldn't it be
either one _or_ the other?

Maybe something like:

if log-output -t hw-detect modprobe -v rtc; then
	update-dev
else
	log "rtc module not loaded"
	if log-output -t hw-detect modprobe -v rtc-dev; then
		update-dev
		# create symlink
	else
		log "rtc-dev module not loaded"
	fi
fi

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---
--- Begin Message --- 
Source: clock-setup
Source-Version: 0.93

We believe that the bug you reported is fixed in the latest version of
clock-setup, which is due to be installed in the Debian FTP archive:

clock-setup_0.93.dsc
  to pool/main/c/clock-setup/clock-setup_0.93.dsc
clock-setup_0.93.tar.gz
  to pool/main/c/clock-setup/clock-setup_0.93.tar.gz
clock-setup_0.93_i386.udeb
  to pool/main/c/clock-setup/clock-setup_0.93_i386.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 449292@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joey Hess <joeyh@debian.org> (supplier of updated clock-setup package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 07 Jan 2008 17:44:45 -0500
Source: clock-setup
Binary: clock-setup
Architecture: source i386
Version: 0.93
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Joey Hess <joeyh@debian.org>
Description: 
 clock-setup - set up clock
 clock-setup - set up clock (udeb)
Closes: 447071 449292
Changes: 
 clock-setup (0.93) unstable; urgency=low
 .
   [ Joey Hess ]
   * Try to load rtc-dev always, as it's a generic module.
 .
   [ dann frazier ]
   * Override the default ntp server with the first server listed in
     netcfg/dhcp_net_servers (if set). Closes: #447071
 .
   [ Joey Hess ]
   * More generic rtc-dev handling. Closes: #449292
 .
   [ Updated translations ]
   * Amharic (am.po) by tegegne tefera
   * Belarusian (be.po) by Hleb Rubanau
   * Dzongkha (dz.po) by Jurmey Rabgay
   * Esperanto (eo.po) by Serge Leblanc
   * Galician (gl.po) by Jacobo Tarrio
   * Korean (ko.po) by Changwoo Ryu
   * Kurdish (ku.po) by Erdal Ronahi
   * Malayalam (ml.po) by Praveen
   * Norwegian Bokmål (nb.po) by Hans Fredrik Nordhaug
   * Norwegian Nynorsk (nn.po) by Håvard Korsvoll
   * Panjabi (pa.po) by A S Alam
   * Polish (pl.po) by Bartosz Fenski
   * Romanian (ro.po) by Eddy Petrișor
   * Slovak (sk.po) by Ivan Masár
Files: 
 25dea8e017139a18cb398cd3f31689a9 862 debian-installer standard clock-setup_0.93.dsc
 204db23ac14157fac954e489112cd670 56979 debian-installer standard clock-setup_0.93.tar.gz
 5eed8d78498aa1027d556fbd694fccb0 34390 debian-installer standard clock-setup_0.93_i386.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHgquW2tp5zXiKP0wRAlHOAJ9GohhMM/Kg9wvuDfeL2QDNadCB7QCeNSTj
6fWJRJzPMA8CWr2gm0g7TXs=
=jWMa
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: