On Mon, Dec 01, 2008 at 06:40:33AM +0100, Frans Pop wrote:
> On Sunday 30 November 2008, Jérémy Bobbio wrote:
> > On Sun, Nov 30, 2008 at 05:26:31PM +0100, Jérémy Bobbio wrote:
> > > The attached patch fix this issue. I have run an installation
> > > through the end without any problem with the patch applied.
> >
> > It lacks a necessary free(). Updated patch attached.
>
> Which misses a ; after the free statement...
>
> I've also tested cdebconf with the patch, but AFAICT it does not fix the
> issue. If I use network-console and play a bit with the size of the
> window from which I ssh (80x24), I can still reproduce exactly the same
> screenshot.
*ahem* Lesson learnt: coding in a room less than 10°C results in hasty
changes. Thanks for doing some extra testing.
> Isn't the real problem that the frontend apparently thinks that showing
> just a single line of a (multi) select list is enough and only splits
> into more than one screen if it cannot fit even a single line in the
> dialog?
Well, the comments inside the code imply than the window should be split
if less than 3 lines of choices would be displayed, but there is
something wrong in the way its done.
> As the patch does not really seem to change or improve anything I'll
> upload cdebconf with just the fix for the fall-back languages.
The issue probably requires more invasive changes in the newt frontend;
let's postpone them to better times.
Cheers,
--
Jérémy Bobbio .''`.
lunar@debian.org : :Ⓐ : # apt-get install anarchism
`. `'`
`-
Attachment:
signature.asc
Description: Digital signature