Bug#502240: cdebconf: should not drop fall-back languages
Otavio Salvador <otavio@debian.org> writes:
> Jérémy Bobbio <lunar@debian.org> writes:
>
>> tags 502240 + patch
>> thanks
>>
>> On Tue, Oct 14, 2008 at 09:39:36PM +0200, Frans Pop wrote:
>>> When localechooser sets debconf/language to a set of languages (preferred
>>> + fall-back languages, e.g. se_NO:nb_NO:nb:no_NO:no:nn_NO:nn:da:sv:en for
>>> Northern Sami), cdebconf should ensure that *all* relevant translations
>>> are kept when translations are dropped with DEBCONF_DROP_TRANSLATIONS
>>> set.
>>
>> Indeed, cdebconf was only keeping translation for the first language
>> of the set.
>>
>> The attached patch should fix this, but as I am currently lacking a
>> proper environment to do a full d-i test, it would be great if someone
>> could verify that it really fixes the issue.
>
> I've did an installation using your patch and it looks to solve
> it. Could you commit it? Want me to upload cdebconf or you can take
> care of it?
Bellow goes the comments done by Colin at #debian-boot, for reference.
18:38 <cjwatson> Lunar^: it looks fine except that you leak wantlang on the break path
18:39 <cjwatson> Lunar^: and I would suggest moving the char *wantlang declaration into the for loop to make its scope clear
18:39 <cjwatson> (which avoids having to think "can wantlang be used outside this loop?"
18:39 <cjwatson> )
--
O T A V I O S A L V A D O R
---------------------------------------------
E-mail: otavio@debian.org UIN: 5906116
GNU/Linux User: 239058 GPG ID: 49A5F855
Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
you the whole house."
Reply to: