[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#498784: mdcfg hangs when there is no partition for spare device



On Sat, Sep 13, 2008 at 10:36:59PM -0700, Ryan Niebur wrote:
> On Sat, Sep 13, 2008 at 11:44:26AM +0300, Martin Michlmayr wrote:
> > I chose 1 partition (sda2) for RAID in partman and entered the RAID
> > config tool.  I then chose RAID1 with 1 active partition and 1 spare
> > partition.  I got a prompt asking which partition to use for the
> > active one and chose sda2.  Then mdcfg hangs.  Looking at the code, it
> > does (lines 329-331):
> > 
> 
> Attached is a (trivial, and of course tested) patch that fixes this.

Well, the hang is due to a regression in cdebconf for which a fix has
already been commited (#498846), upload pending.

Nevertheless, I still think that it would make sense to commit your
patch to mdcfg: silently recovering from an error does not feel like
good code to me.

Cheers,
-- 
Jérémy Bobbio                        .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   

Attachment: signature.asc
Description: Digital signature


Reply to: