[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#498795: Should automatically load required udebs for the nslu2



* Frans Pop <elendil@planet.nl> [2008-06-23 16:29]:
> > Yep, it's annoying.  IMHO it would be nice if we could specify a list
> > of modules for specific subarches that would be loaded even when
> > you're in lowmem level2.
> 
> Assuming s/modules/udebs/: add them in /var/cache/anna/include.
> When/how to best do that is up to you.

That's a great idea, Frans!  Actually, /var/cache/anna/include won't
work in this case because on lowmem systems some things from
/var/cache/anna/include are ignored, so you cannot queue up
partman-auto and partman-ext3 this way.  However, anna-install works.

I came up with the patch below which I tested on a QNAP device in
(faked) lowmem level 2.

Gordon, can you test this on a NSLU2?

Frans, any comments on the patch?

The only thing I don't like is that the modules installed via
anna-install won't show up in the list of modules that users get to
select from (iirc this is not the case when using
/var/cache/anna/include).  I fear this might confuse some users who
are known to the etch installer, but I still think it makes sense to
load them automatically and to document this change in the release
notes.

The alternative would be to modify anna.c and to move the
take_includes/drop_excludes calls right after the if (lowmem_mode)...
and then use /var/cache/anna/include.  I don't think this would have
any negative effects, but I'm not sure.  Colin/Frans?

Index: src/lib/debian-installer-startup.d/S80anna-install
===================================================================
--- src/lib/debian-installer-startup.d/S80anna-install	(revision 0)
+++ src/lib/debian-installer-startup.d/S80anna-install	(revision 0)
@@ -0,0 +1,21 @@
+## Make sure some udebs are loaded automatically, even in lowmem level 2
+
+kver=$(uname -r)
+machine=$(grep "^Hardware" /proc/cpuinfo | sed 's/Hardware\s*:\s*//')
+case "`archdetect`" in
+	arm*/ixp4xx)
+		case "$machine" in
+			"Linksys NSLU2")
+				anna-install partman-auto
+				anna-install partman-ext3
+				anna-install usb-storage-modules-$kver-di
+			;;
+		esac
+	;;
+	mipsel/cobalt)
+		anna-install partman-auto
+		anna-install partman-ext2r0
+		anna-install partman-ext3
+	;;
+esac
+
Index: src/lib/debian-installer-startup.d/Makefile
===================================================================
--- src/lib/debian-installer-startup.d/Makefile	(revision 55567)
+++ src/lib/debian-installer-startup.d/Makefile	(working copy)
@@ -20,7 +20,8 @@
 	S10syslog \
 	S20templates \
 	S35term \
-	S37speakup
+	S37speakup \
+	S80anna-install
 
 ifeq ($(DEB_HOST_ARCH_OS),linux)
   ifneq (,$(filter i386 amd64,$(DEB_HOST_ARCH_CPU)))

-- 
Martin Michlmayr
http://www.cyrius.com/



Reply to: