[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFC] Possible way of fixing this [was Re: [PATCH] Queue atl2-modules for installation if it is in use.

On Wed, Aug 13, 2008 at 05:53:03PM +0800, Glenn Saberton wrote:
> After looking at finnish-install, the speakup script looked like a nice
> way to do it. Heres a preliminary patch. tested and installed the
> correct flavour kernel for my eee.

Good. :)

> […]
> +ATL2=$(lsmod | grep ^atl2 | cut -d" " -f1)
> +if [ -n "$ATL2" ]; then

What about symplifing this to the following:
  if lsmod | grep -q '^atl2 '; then

Otherwise, looks fine to me.

Jérémy Bobbio                        .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 

Attachment: signature.asc
Description: Digital signature

Reply to: