[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#492862: marked as done (grub-installer: Fails on virtio disks)

Your message dated Wed, 30 Jul 2008 19:05:03 +0200
with message-id <20080730170503.GB29980@qamar>
and subject line Re: Bug#492862: grub-installer: Fails on virtio disks
has caused the Debian Bug report #492862,
regarding grub-installer: Fails on virtio disks
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
492862: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=492862
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: grub-installer
Severity: normal

grub-installer currently fails on virtio disks (/dev/vd[a-z]) as grub
does not list virtio disks in device.map.

One quick test showed that GRUB 2 was able to cope with these devices
nicely.  The attached patch makes grub-installer default to GRUB 2 when
boot is on virtio disks.  This is pretty hacky, but worked fine in my
tests.

Cheers,
-- 
Jérémy Bobbio                        .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   

commit 30b8e4591943a2e2a3b9d73687ea40281575241e
Author: Jérémy Bobbio <lunar@debian.org>
Date:   Tue Jul 29 11:49:34 2008 +0200

    Use GRUB 2 by default on virtio disks

diff --git a/packages/arch/i386/grub-installer/debian/changelog b/packages/arch/i386/grub-installer/debian/changelog
index b1456f3..537001e 100644
--- a/packages/arch/i386/grub-installer/debian/changelog
+++ b/packages/arch/i386/grub-installer/debian/changelog
@@ -1,3 +1,10 @@
+grub-installer (1.33) UNRELEASED; urgency=low
+
+  [ Jérémy Bobbio ]
+  * Use GRUB 2 by default on virtio disks.
+
+ -- Jérémy Bobbio <lunar@debian.org>  Tue, 29 Jul 2008 11:46:30 +0200
+
 grub-installer (1.32) unstable; urgency=low
 
   [ Updated translations ]
diff --git a/packages/arch/i386/grub-installer/grub-installer b/packages/arch/i386/grub-installer/grub-installer
index 2b16484..d5eaafd 100755
--- a/packages/arch/i386/grub-installer/grub-installer
+++ b/packages/arch/i386/grub-installer/grub-installer
@@ -258,9 +258,14 @@ case $prefix in
     /dev/mapper)
 	disc_offered_devfs="$bootfs"
 	;;
-    /dev/[hsv]d[a-z]|/dev/xvd[a-z]|/dev/cciss/c[0-9]d[0-9]|/dev/ida/c[0-9]d[0-9])
+    /dev/[hs]d[a-z]|/dev/xvd[a-z]|/dev/cciss/c[0-9]d[0-9]|/dev/ida/c[0-9]d[0-9])
 	disc_offered_devfs="$prefix"
 	;;
+    /dev/vd[a-z])
+	disc_offered_devfs="$prefix"
+	# Use GRUB 2 by default on virtio disks
+	db_set grub-installer/grub2_instead_of_grub_legacy true
+	;;
     *)
 	disc_offered_devfs=$(echo "$bootfs_devfs" | sed "s:\(.*\)/.*:\1/disc:")
 	;;

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
On Tue, Jul 29, 2008 at 11:59:06PM +0200, Robert Millan wrote:
> On Tue, Jul 29, 2008 at 03:53:46PM +0200, Jérémy Bobbio wrote:
> > 
> > grub-installer currently fails on virtio disks (/dev/vd[a-z]) as grub
> > does not list virtio disks in device.map.
> 
> Does this address the problem?
> 
> grub (0.97-42) unstable; urgency=high
>   [...]
>   * patches/use_grub-probe_in_grub-install.diff: Use grub-mkdevicemap when
>     device.map needs to be regenerated (this brings in Virtio support, and
>     probably others).
>     (Closes: #491745)
> 
> (pending unblock)

Yes it does.  :)

-41 was in testing and so installed by default.  Manually installing
grub 0.97-42 in the chroot before running grub-installer worked without
any trouble.

Cheers,
-- 
Jérémy Bobbio                        .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: