[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#488494: marked as done (cdebconf: Make the dark theme even more readable)



Your message dated Wed, 16 Jul 2008 15:17:03 +0000
with message-id <E1KJ8kZ-0005p4-3I@ries.debian.org>
and subject line Bug#488494: fixed in cdebconf 0.132
has caused the Debian Bug report #488494,
regarding cdebconf: Make the dark theme even more readable
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
488494: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=488494
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: cdebconf
Severity: minor
Tags: patch

Hello,

The current dark theme of newt does not use bright colors, and sometimes
uses background colors for no real use, leading to less readability.
The attached patch makes a few fixes.

The current text frontend does not have a dark theme, this adds one for
the linux and bterm console cases.

Samuel

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'oldstable'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.25
Locale: LANG=fr_FR@euro, LC_CTYPE=fr_FR@euro (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash

-- 
Samuel
"And the next time you consider complaining that running Lucid Emacs
19.05 via NFS from a remote Linux machine in Paraguay doesn't seem to
get the background colors right, you'll know who to thank."
(By Matt Welsh)
diff -ur /tmp/cdebconf-0.131/src/modules/frontend/newt/newt.c cdebconf-0.131-mine/src/modules/frontend/newt/newt.c
--- /tmp/cdebconf-0.131/src/modules/frontend/newt/newt.c	2008-05-06 21:32:47.000000000 +0100
+++ cdebconf-0.131-mine/src/modules/frontend/newt/newt.c	2008-06-29 11:43:45.000000000 +0100
@@ -75,24 +75,27 @@
 };
 
 struct newtColors newtAltColorPalette = {
-	"white", "blue", 			/* root fg, bg */
+	/*"white", "blue",*/ 			/* root fg, bg */
+	"white", "black", 			/* root fg, bg */
 	/*"black", "lightgray",*/			/* border fg, bg */
 	"white", "black",			/* border fg, bg */
 	/*"black", "lightgray",*/			/* window fg, bg */
 	"white", "black",			/* window fg, bg */
 	/*"white", "black",*/			/* shadow fg, bg */
-	"white", "blue",			/* shadow fg, bg */
+	"white", "black",			/* shadow fg, bg */
 	/*"red", "lightgray",*/			/* title fg, bg */
 	"yellow", "black",			/* title fg, bg */
-	"brightred", "gray",			/* button fg, bg */
+	/*"brightred", "gray",*/			/* button fg, bg */
+	"black", "lightgray",			/* button fg, bg */
 	"gray", "brightred",			/* active button fg, bg */
 	"white", "gray",			/* checkbox fg, bg */
 	"yellow", "brown",			/* active checkbox fg, bg */
-	"yellow", "blue",			/* entry box fg, bg */
+	/*"yellow", "blue",*/			/* entry box fg, bg */
+	"white", "black",			/* entry box fg, bg */
 	/*"blue", "lightgray",*/			/* label fg, bg */
 	"brightred", "black",			/* label fg, bg */
 	/*"black", "lightgray",*/			/* listbox fg, bg */
-	"lightgray", "black",			/* listbox fg, bg */
+	"white", "black",			/* listbox fg, bg */
 	"yellow", "blue",			/* active listbox fg, bg */
 	/*"black", "lightgray",*/			/* textbox fg, bg */
 	"white", "black",			/* textbox fg, bg */
@@ -100,12 +103,14 @@
 	/*"white", "blue",*/			/* help line */
 	"white", "black",			/* help line */
 	"yellow", "blue",			/* root text */
-	"blue",					/* scale full */
-	"red",					/* scale empty */
+	/*"blue",*/					/* scale full */
+	"gray",					/* scale full */
+	/*"red",*/					/* scale empty */
+	"lightgray",				/* scale empty */
 	"blue", "lightgray",			/* disabled entry fg, bg */
 	/*"black", "lightgray",*/			/* compact button fg, bg */
-	"lightgray", "black",			/* compact button fg, bg */
-	"yellow", "gray",			/* active & sel listbox */
+	"white", "black",			/* compact button fg, bg */
+	"black", "lightgray",			/* active & sel listbox */
 	"black", "brown"			/* selected listbox */
 };
 
diff -ur /tmp/cdebconf-0.131/src/modules/frontend/text/text.c cdebconf-0.131-mine/src/modules/frontend/text/text.c
--- /tmp/cdebconf-0.131/src/modules/frontend/text/text.c	2008-04-09 17:34:02.000000000 +0100
+++ cdebconf-0.131-mine/src/modules/frontend/text/text.c	2008-06-29 11:34:22.000000000 +0100
@@ -751,10 +751,18 @@
 static int text_initialize(struct frontend *obj, struct configuration *conf)
 {
 	struct frontend_data *data = NEW(struct frontend_data);
+	char *term = getenv("TERM");
+	char *palette = getenv("FRONTEND_BACKGROUND");
 	data->previous_title = NULL;
 	obj->data = data;
 	obj->interactive = 1;
 	signal(SIGINT, SIG_IGN);
+	if (palette && !strcmp(palette, "dark") &&
+			term && (!strcmp(term, "linux") || !strcmp(term, "bterm"))) {
+		/* Hard-code for these cases */
+		printf("\e[37m\e[40m\e[1m\e[H\e[J");
+		fflush(stdout);
+	}
 	return DC_OK;
 }
 

--- End Message ---
--- Begin Message ---
Source: cdebconf
Source-Version: 0.132

We believe that the bug you reported is fixed in the latest version of
cdebconf, which is due to be installed in the Debian FTP archive:

cdebconf-gtk-udeb_0.132_amd64.udeb
  to pool/main/c/cdebconf/cdebconf-gtk-udeb_0.132_amd64.udeb
cdebconf-newt-udeb_0.132_amd64.udeb
  to pool/main/c/cdebconf/cdebconf-newt-udeb_0.132_amd64.udeb
cdebconf-priority_0.132_all.udeb
  to pool/main/c/cdebconf/cdebconf-priority_0.132_all.udeb
cdebconf-text-udeb_0.132_amd64.udeb
  to pool/main/c/cdebconf/cdebconf-text-udeb_0.132_amd64.udeb
cdebconf-udeb_0.132_amd64.udeb
  to pool/main/c/cdebconf/cdebconf-udeb_0.132_amd64.udeb
cdebconf_0.132.dsc
  to pool/main/c/cdebconf/cdebconf_0.132.dsc
cdebconf_0.132.tar.gz
  to pool/main/c/cdebconf/cdebconf_0.132.tar.gz
cdebconf_0.132_amd64.deb
  to pool/main/c/cdebconf/cdebconf_0.132_amd64.deb
libdebconfclient0-dev_0.132_amd64.deb
  to pool/main/c/cdebconf/libdebconfclient0-dev_0.132_amd64.deb
libdebconfclient0-udeb_0.132_amd64.udeb
  to pool/main/c/cdebconf/libdebconfclient0-udeb_0.132_amd64.udeb
libdebconfclient0_0.132_amd64.deb
  to pool/main/c/cdebconf/libdebconfclient0_0.132_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 488494@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Frans Pop <fjp@debian.org> (supplier of updated cdebconf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 16 Jul 2008 13:34:27 +0200
Source: cdebconf
Binary: cdebconf libdebconfclient0 libdebconfclient0-dev cdebconf-udeb cdebconf-priority libdebconfclient0-udeb cdebconf-slang-udeb cdebconf-newt-udeb cdebconf-text-udeb cdebconf-gtk-udeb
Architecture: source all amd64
Version: 0.132
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Frans Pop <fjp@debian.org>
Description: 
 cdebconf   - Debian Configuration Management System (C-implementation)
 cdebconf-gtk-udeb - Gtk+ frontend for Debian Configuration Management System (udeb)
 cdebconf-newt-udeb - Newt frontend for Debian Configuration Management System (udeb)
 cdebconf-priority - Change debconf priority (udeb)
 cdebconf-slang-udeb - S-Lang frontend for Debian Configuration Management System (udeb)
 cdebconf-text-udeb - Plain text frontend for Debian Configuration Management System (udeb)
 cdebconf-udeb - Debian Configuration Management System (C-implementation) (udeb)
 libdebconfclient0 - Debian Configuration Management System (C-implementation)
 libdebconfclient0-dev - Development files for cdebconf
 libdebconfclient0-udeb - Debian Configuration Management System (C-implementation) (udeb)
Closes: 247744 486892 488494
Changes: 
 cdebconf (0.132) unstable; urgency=low
 .
   [ Joey Hess ]
   * Add a separate queue for noninteractive questions, so that things can
     be done when these questions would be displayed. This is a bit hackish;
     debconf's method of letting questions determine if they are interactive or
     not is really better. But this doesn't need huge changes to cdebconf.
   * Handle the special case of a noninteractive select with no (or a bad)
     default the same as debconf does; when such a question is asked,
     set the value to the first item in the select list.
     Closes: #486892, #247744
 .
   [ Frans Pop ]
   * Apply patch from Samuel Thibault to improve dark theme in newt frontend
     and add support for a dark theme in the text frontend if used with
     "linux" or "bterm" consoles. Closes: #488494.
 .
   [ Updated translations ]
   * Basque (eu.po) by Iñaki Larrañaga Murgoitio
   * Italian (it.po) by Milo Casagrande
   * Russian (ru.po) by Yuri Kozlov
   * Turkish (tr.po) by Mert Dirik
Checksums-Sha1: 
 e5a6921e29bdaabeeea3211ee63b9f7d5d44c796 1345 cdebconf_0.132.dsc
 f2c427cd10b2815f3a63ef883880141cef3d2595 301443 cdebconf_0.132.tar.gz
 d7ebe9141ebdd6e6f7b78c7e76dd8c16aa537b17 2728 cdebconf-priority_0.132_all.udeb
 897e21040c4c1362c1b49390ec8722ba9d2172c0 167552 cdebconf_0.132_amd64.deb
 d8b5ba0623363f3a4b007a647de215f18efd44d5 37076 libdebconfclient0_0.132_amd64.deb
 7f3bf411b4296e0c348cee1c360ba4ee96852785 41956 libdebconfclient0-dev_0.132_amd64.deb
 4f6e96c5bcd2bdbf37a12082cfa5fc660a0a2649 78306 cdebconf-udeb_0.132_amd64.udeb
 5e1dfbd806dde07b636a2f838ae922311c15ca42 3296 libdebconfclient0-udeb_0.132_amd64.udeb
 dab41910463f023c5332d156967fbfbcc77fe245 18700 cdebconf-newt-udeb_0.132_amd64.udeb
 0e6a9dcd752542cc3ca69b7ac0681b24b5c13f7d 19516 cdebconf-text-udeb_0.132_amd64.udeb
 31589359a8297d090417e3c2bf26905d10454457 30360 cdebconf-gtk-udeb_0.132_amd64.udeb
Checksums-Sha256: 
 adfda4b8bc25f3f339ff1ecd71e6751783d3520585c9cb9e5367589642b22c42 1345 cdebconf_0.132.dsc
 37725efaf241993cbe69b874ef0b7a128cf3700c33fd16e8014d03e068be118a 301443 cdebconf_0.132.tar.gz
 91ff6e6e080039ce46a0629d095abeedb2049aac7b1197c2e114398b9b9ebcd7 2728 cdebconf-priority_0.132_all.udeb
 76faa3ec5053d225f9c36c7c049fc3b55c88404217475c36ab4483033971b864 167552 cdebconf_0.132_amd64.deb
 f0607d85fef56f3bc73153ed9a7b123dae892648299a2f12cd133be6835aeb28 37076 libdebconfclient0_0.132_amd64.deb
 84fe974f63f82b8ec699445067e6e708d992afb7ed015702b11d2885f7f951a6 41956 libdebconfclient0-dev_0.132_amd64.deb
 26b602e6c9d7ec669d1a1709b5f0dc3082ece1078a6f074cd35072e3822ecbed 78306 cdebconf-udeb_0.132_amd64.udeb
 1a111ce59d5f640e24dc500481a3d3ea70b93fd723681e291187740d2dfd5367 3296 libdebconfclient0-udeb_0.132_amd64.udeb
 5c007e4e9a020547b0229806d22a2c60c6df409bbafb02a9eab1b092fc7ef5e5 18700 cdebconf-newt-udeb_0.132_amd64.udeb
 7a2bc6c459578a3e0949e77387f8444512ca836523c05d520b9ed54a0475130a 19516 cdebconf-text-udeb_0.132_amd64.udeb
 eb752f9ef046049424844d9443984733c337e761ca7ff1dca44d44c87543fc99 30360 cdebconf-gtk-udeb_0.132_amd64.udeb
Files: 
 4b3b407f09b196d296362b598dd37eeb 1345 utils optional cdebconf_0.132.dsc
 e4cf4f96af247675cf8831579ff06ce3 301443 utils optional cdebconf_0.132.tar.gz
 065f70580a034fb4d268bf331e90c2e0 2728 debian-installer standard cdebconf-priority_0.132_all.udeb
 8f50b71ec4531681c97c2059d238277a 167552 utils extra cdebconf_0.132_amd64.deb
 9775fd77be822c72c6721b00a0e697be 37076 libs optional libdebconfclient0_0.132_amd64.deb
 aa18534f8bc3a7f4ada9f326ddd71393 41956 libdevel optional libdebconfclient0-dev_0.132_amd64.deb
 2f041d94b2d7fb6f7dd82b1ad583d48c 78306 debian-installer standard cdebconf-udeb_0.132_amd64.udeb
 8e553149b6be286ee07250d7ae21c14c 3296 debian-installer optional libdebconfclient0-udeb_0.132_amd64.udeb
 b52171c403d44b9e8e4cd5a2d441dc33 18700 debian-installer optional cdebconf-newt-udeb_0.132_amd64.udeb
 747267cdb9305a2f76f0934509274b89 19516 debian-installer optional cdebconf-text-udeb_0.132_amd64.udeb
 7dd71795b7eb0e4a6246e40746f8d752 30360 debian-installer optional cdebconf-gtk-udeb_0.132_amd64.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkh+DsAACgkQgm/Kwh6ICoSNTwCgz3KM7GjEseu/Q2KBXj78zb+T
80UAn2g3lve+KE07PxebTv5whL9ehpSD
=kuQb
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: