[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] firmware loading support



Quoting Joey Hess (joeyh@debian.org):

This is great work, Joey. Making firmware-mandatory hardware work with
D-I would be a giant step. So, despite this breaking again the slow
progress in localization (about 25 complete langs as of now), I warmly
applause.


Comments on templates (very nitpicking, indeed):

> diff --git a/packages/hw-detect/debian/hw-detect.templates b/packages/hw-detect/debian/hw-detect.templates
> index 5301467..cf31ef3 100644
> --- a/packages/hw-detect/debian/hw-detect.templates
> +++ b/packages/hw-detect/debian/hw-detect.templates
> @@ -67,9 +67,20 @@ Default: false
>  # :sl2:
>  _Description: Load missing drivers from removable media?
>   A driver for your hardware is not available. You may need
> - to load drivers from removable media, such as a driver floppy.
> + to load drivers from removable media, such as a USB stick, or driver floppy.

Here you mention "or driver floppy"


>   If you have such media available now, insert it, and continue.
>  
> +Template: hw-detect/load_firmware
> +Type: boolean
> +Default: false
> +# :sl2:
> +_Description: Load missing firmware from removable media?
> + Some of your hardware needs firmware files to operate. The firmware
> + can be loaded from removable media, such as a USB stick or floppy.

And here just "or floppy". I think that last wording is slightly the
best of the two.


> + If you have such media available now, insert it, and continue.

That sentence could be factorized out in its own paragraph


> + .
> + The missing firmware files are: ${FILES}
> +

Missing sentence dot?  (that's debatable: should a dot come after a
list of files? I'd say yes)



> diff --git a/packages/hw-detect/debian/hw-detect.templates b/packages/hw-detect/debian/hw-detect.templates
> index cf31ef3..a06b928 100644
> --- a/packages/hw-detect/debian/hw-detect.templates
> +++ b/packages/hw-detect/debian/hw-detect.templates
> @@ -81,6 +81,11 @@ _Description: Load missing firmware from removable media?
>   .
>   The missing firmware files are: ${FILES}
>  
> +Template: base-installer/progress/hw-detect
> +Type: text
> +# :sl1:
> +_Description: Installing firmware...
> +

Move to sublevel 2? Is that progress text shown on *any* default install?




Attachment: signature.asc
Description: Digital signature


Reply to: