Frans Pop wrote: > On Monday 23 June 2008, Joey Hess wrote: > > Here's an initial attempt at support for loading missing firmware from > > removable media. Completly untested. > > 0001: How do you know which version of the udev script you get? I was assuming we're remove it from udev-udeb. Putting the modified one there would also be ok. > 0003: Having the two loops looks broken > In so far that the second loop is likely to copy files that were already > installed in the first loop. The second loop is (supposed to) loop over $files, which will only be the names of firmware files the kernel has requested, not udebs/debs. (Typo fix attached.) -- see shy jo
From f6ddf1c66a7420bdf8f42a45dc019ad228f8e311 Mon Sep 17 00:00:00 2001 From: Joey Hess <joey@kodama.kitenet.net> Date: Sun, 22 Jun 2008 21:50:22 -0400 Subject: [PATCH] typo fix --- packages/hw-detect/check-missing-firmware.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/hw-detect/check-missing-firmware.sh b/packages/hw-detect/check-missing-firmware.sh index 5e079ba..ab49df3 100755 --- a/packages/hw-detect/check-missing-firmware.sh +++ b/packages/hw-detect/check-missing-firmware.sh @@ -59,7 +59,7 @@ while read_log && ask_load_firmware; do # also look for loose firmware files on the media if mountmedia; then - for file in $(files); do + for file in $files; do if [ -e "/media/$file" ]; then mkdir -p /lib/firmware rm -f "/lib/firmware/$file" @@ -70,7 +70,7 @@ while read_log && ask_load_firmware; do fi # remove and reload modules so they see the new firmware - for module in $(modules); do + for module in $modules; do modprobe -r $module || true modprobe $module || true done -- 1.5.5.4
Attachment:
signature.asc
Description: Digital signature