Re: [patch] Add support for KuroBox Pro to oldsys-preseed
* Per Andersson <avtobiff@gmail.com> [2008-06-19 11:40]:
> The default IP address is 192.168.11.150, there is no
> default gateway and ns but I set it to 192.168.11.1
> because that is what I would have expected by default.
Is this the default IP used by the Kurobox or how did you come up with
(such an unusual) IP address?
> + path=/tmp/oldsys-preseed
> + mkdir -p $path/rootfs
> + mount -t jffs2 -o ro /dev/mtdblock2 $path/rootfs || true
This means we'll need a jffs2 udeb for Orion. Please take a look at
svn://svn.d-i.alioth.debian.org/svn/d-i/trunk/packages/kernel/linux-modules-di-armel-2.6
> + INTERFACE=eth0
> + parse_unix_tree "$path/rootfs"
These quotes can be removed.
> + netinfo=$path/rootfs/etc/netinfo
> + if [ -e "$netinfo" ]; then
> + usage=$(cat "$netinfo" | grep "^my_ipaddress" | sed 's/.*=//')
Should you take whitespace into consideration here? i.e. is "foo =
bar" allowed in those config files?
> + hostinfo=$path/rootfs/etc/host.info
> + if [ -e "$hostinfo" ]; then
> + HOSTNAME=$(cat "$hostinfo" | grep "^hostname" | sed 's/.*=//')
> + fi
Should we have a
unset_matching_var "HOSTNAME" "KUROBOX-PRO"
somewhere?
> + umount $path/rootfs
> + rmdir $path/rootfs $path
I suggest to add a || true here
Geert's suggestions also seem worthwhile to me.
Apart from this, the patch looks good.
--
Martin Michlmayr
http://www.cyrius.com/
Reply to: