Re: [PATCH 3/3 v6] Add WPA support to netcfg

[Glenn Saberton <gsaberton@foomagic.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Christian Perrier wrote:
> Quoting Glenn Saberton (gsaberton@foomagic.org):
> 
>> diff --git a/packages/netcfg/debian/netcfg-common.templates b/packages/netcfg/debian/netcfg-common.templates
>> index 973411e..dfe5522 100644
>> --- a/packages/netcfg/debian/netcfg-common.templates
>> +++ b/packages/netcfg/debian/netcfg-common.templates
>> @@ -56,6 +56,14 @@ _Description: Wireless ESSID for ${iface}:
>>   of the wireless network you would like ${iface} to use. To skip wireless
>>   configuration and continue, leave this field blank.
>>  
>> +Template: netcfg/wireless_security_type
>> +Type: select
>> +__Choices: WEP/Open, WPA PSK
>> +# :sl2:
>> +_Description: Wireless Network Type for ${iface}:
>> + Choose WEP/Open if the network is open or secured with WEP.
>> + Choose WPA if the network is a WPA PSK protected network.
> 
> "WPA PSK-protected", maybe. 
> 
> 
>> +
>>  Template: netcfg/wireless_wep
>>  Type: string
>>  # :sl1:
>> @@ -80,6 +88,19 @@ _Description: Invalid WEP key
>>   the next screen carefully on how to enter your WEP key correctly, and try
>>   again.
>>  
>> +Template: netcfg/invalid_pass
>> +Type: error
>> +# :sl2:
>> +_Description: Invalid passphrase
>> + The WPA PSK passphrase was either too long (more than 64 characters)
>> + or too short (less than 8 characters).
>> +
>> +Template: netcfg/wireless_wpa
>> +Type: string
>> +# :sl1:
>> +_Description: WPA passphrase for wireless device ${iface}:
>> + Enter a passphrase for WPA PSK authentication.
>> +
>>  Template: netcfg/invalid_essid
>>  Type: error
>>  # :sl2:
>> @@ -87,6 +108,22 @@ _Description: Invalid ESSID
>>   The ESSID "${essid}" is invalid. ESSIDs may only be up to 32 characters,
>>   but may contain all kinds of characters.
>>  
>> +Template: netcfg/wpa_progress
>> +Type: text
>> +# :sl1:
>> +_Description: Attempting to exchange keys with Access Point.
> 
> As this is a progress text, there shouldn't be any final dot but an
> ellipsis:
> 
> Attempting to exchange keys with the access point...
> 
> No need to capitalize "access point".
> 
>> +
>> +Template: netcfg/wpa_success_note
>> +Type: text
>> +# :sl1:
>> +_Description: Success!
> 
> WPA connection succeeded
> 
>> +
>> +Template: netcfg/wpa_supplicant_failed
>> +Type: note
>> +# :sl1:
>> +_Description: Key exchange and association failed
> 
> Failure of key exchange and association
> 
>> + Please recheck the ESSID and passphrase you entered.
> 
> The exchange of keys and association with the access point
> failed. Please check the WPA parameters you provided.
> 
> 
Sounds good to me. Thanks, will have these changes in the next set.

Cheers

Glenn
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkhcz2wACgkQV8GyuTwyskN2pwCfSlggIAAgkrIIcv0742VEKZYm
kEIAni/UGR6D2rGEw8cY/beIMbvBApx8
=b5rR
-----END PGP SIGNATURE-----