[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#486907: pass default_desktop parameter to win32-loader



Package: debian-installer
Severity: wishlist
Tags: patch

Please make desktop selection in win32-loader explicit by passing it the
default_desktop parameter.  Attached patch doesn't change current behaviour,
but has two advantages:

  - Makes it obvious what change would be required for win32-loader to
    default to kde or xfce.

  - Makes it easier to do that change via sed invocation (line mangling
    instead of insertion).

With this change, win32-loader can be fixed on Xfce or KDE CDs with less
hassle.

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-6-amd64
Locale: LANG=ca_AD.UTF-8, LC_CTYPE=ca_AD.UTF-8 (charmap=UTF-8)
Index: config/x86.cfg
===================================================================
--- config/x86.cfg	(revision 53653)
+++ config/x86.cfg	(working copy)
@@ -98,6 +98,7 @@
 		\
 		(echo -en "[installer]\n"; \
 		echo -en "arch=$(ARCH)\n"; \
+		echo -en "default_desktop=gnome\n"; \
 		if [ -n "$(INITRD_GTK)" ]; then \
 			echo -en "$(ARCH)/linux=linux\n$(ARCH)/initrd=initrd.gz\n"; \
 			echo -en "$(ARCH)/gtk/linux=linux\n$(ARCH)/gtk/initrd=initrdg.gz\n"; \
@@ -172,6 +173,7 @@
 	# win32-loader.ini
 	(echo -en "[installer]\n"; \
 	echo -en "arch=$(ARCH)\n"; \
+	echo -en "default_desktop=gnome\n"; \
 	if [ -n "$(INITRD_GTK)" ]; then \
 		echo -en "$(ARCH)/linux=install/vmlinuz\n$(ARCH)/initrd=install/initrd.gz\n"; \
 		echo -en "$(ARCH)/gtk/linux=install/vmlinuz\n$(ARCH)/gtk/initrd=install/gtk/initrd.gz\n"; \
@@ -227,6 +229,7 @@
 	# win32-loader.ini
 	(echo -en "[installer]\n"; \
 	echo -en "arch=$(ARCH)\n"; \
+	echo -en "default_desktop=gnome\n"; \
 	if [ "$(TYPE)" = "netboot/gtk" ]; then \
 		echo -en "user_interface=graphical\n"; \
 		echo -en "$(ARCH)/gtk/linux=linux\n$(ARCH)/gtk/initrd=initrd.gz\n"; \

Reply to: