On Tuesday 20 May 2008, David Härdeman wrote: > > General: could you please start using the preferred method for case > > statements (4 space indent for tests; single tab indent for code)? > > Umm, the patch didn't add any case statements? OK, but I did notice a few in the patch anyway :-) It was just a general comment anyway. > > + if ! log-output -t blockdev-keygen \ > > + mount "$device" "$mountpoint" > /dev/null 2>&1; then > > + return 1 > > + fi > > > > Please use log-output for things like this as it at least gives us a > > clue what goes wrong if there are errors. Same for unmounts. > > Umm, it does use log-output? But then the output should not be redirected to /dev/null, right? I'm also not sure it's used everywhere, but I mainly noticed the redirects. Cheers, FJP
Attachment:
signature.asc
Description: This is a digitally signed message part.