Bug#478591: cdebconf-entropy: Dialog texts and buttons

[Max Vozeler <xam@debian.org>]

On Sun, May 04, 2008 at 05:50:34PM +0200, Frans Pop wrote:
> On Sunday 04 May 2008, Max Vozeler wrote:
> > Patch attached -
> 
> Hmm. Should the string not also be changed in the templates and .c code of 
> cdebconf-entropy for all frontends?

Yep, you are right.

Other issues:

 o Variable expansion is not done for the fallback strings
   provided in the frontends themselves.

 o It seems like variable expansion is not done for template
   "snippets" like partman-crypto/entropy-success (?)

  At least it didn't work in my testing. Not sure why. From 
  a quick reading of the code, it uses question_get_text() on
  the template, which I understand should do the expansion.

> Also, that does not cover the other suggestion I had for a string change. We 
> should probably do both at the same time.
> 
> ! I also suggest changing:
> !     Enter random characters or move mouse randomly
> ! to:
> !     Enter random characters or make random movements with your mouse

I'm neutral about this change; Both versions sound good to
my non-native ear.

> +_Description: You can help speed up the process by entering random
> +characters on the keyboard or by making random movements with the mouse,
> +or just wait until enough key data has been collected (which can take a
> +long time).
> 
> And today I noticed something else. When no action is taken (keyboard or 
> mouse) no entropy is gathered _at all_. So the last part of the sentence 
> above (or just wait ...) is IMO not correct.

Indeed. We should probably reword the templates to drop
any mention of "just wait".

	Max