[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] cdebconf: Fix *_can_align() signatures to match the prototype



On Sun, May 04, 2008 at 03:41:54PM +0200, Max Vozeler wrote:
> gcc correctly warns about a pointer mismatch assigning to
> methods.can_align for newt and the generic default:
> 
>   struct frontend_module {
>       ..
>       bool (*can_align)(struct frontend *, struct question *);
> 
>   vs.
> 
>  static bool newt_can_align(struct frontend *obj)
>  static bool frontend_can_align(struct frontend *ui)
> 
> The attached patch fixes those two to take the additional
> struct question * parameter.

Looks fine. Please commit. :)
(Well, without your previous patch in the changelog, please.)

Cheers,
-- 
Jérémy Bobbio                        .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   

Attachment: signature.asc
Description: Digital signature


Reply to: