On Wednesday 30 April 2008, Robert Millan wrote: > Comments? That whole section is preceded by these comments: ## This is copied from update-grub; we've requested that it be moved ## to a utility or shell library Seems like this has now happened and that grub-probe is the utility we've been waiting for? If that is the case, I don't think there should be any objections to something like this patch. It should however then also update these preceding comments, and probably the function itself should be renamed. I also miss some kind of error handling in case grub-probe fails. IMO the following should be checked _before_ we merge this patch: 1) does grub-probe produce the same output for the same input 2) does it support _all_ the different device types that grub-installer supports, _including_ the recently added ones (vdX and xvdX) and for example multipath (/dev/mapper/mpath*); if not these should be added in grub-probe *first* 3) does it also support gnu*, freebsd* and netbsd* host OS and, if not, does it return an error; if not we should keep that coded in grub-installer Cheers, FJP
Attachment:
signature.asc
Description: This is a digitally signed message part.