Bug#476524: debian-installer: DI Manual Bug: the use of killall.sh as described kills itself
reassign 476524 installation-guide
tag 476524 pending
thanks
On Friday 18 April 2008, Durk Strooisma wrote:
> Hmm but killall.sh doesn't use pidof... Well I'm not sure if my problem
> is clear, but correct me if I'm wrong.
>
> Anyway, to clarify: killall.sh works perfectly, but people should not use
> it with an argument; specially not with "dhclient" as argument. Using an
> argument with killall.sh is stated in the DI Manual and definately wrong
> usage. So it's a bug in the manual, not in killall.sh. I guess it's even
> expected behaviour of killall.sh.
You are completely correct. The argument is 100% bogus and I have corrected
this in the installation guide.
One could argue though that the killall.sh script is not very failsafe and
even possibly harmful as its sed statement does allow for random other
processes that match its rather simplistic regexp to get caught in the
kill. Especially for "pump" that could well be a real issue. I think I'll
file a separate bug report for that.
Thank you very much for the report.
Cheers,
FJP
Reply to: