[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFC] [PATCH] WPA PSK support for netcfg

Quoting Glenn Saberton (gsaberton@foomagic.org):

Comments about templates wording...

> diff -Nurb ../netcfg-1.43/debian/netcfg-common.templates netcfg-1.43/debian/netcfg-common.templates
> --- ../netcfg-1.43/debian/netcfg-common.templates	2008-03-08 05:00:20.000000000 +0900
> +++ netcfg-1.43/debian/netcfg-common.templates	2008-04-18 18:39:30.000000000 +0800
> @@ -56,6 +56,15 @@
>   of the wireless network you would like ${iface} to use. To skip wireless
>   configuration and continue, leave this field blank.
> +Template: netcfg/wireless_security_type
> +Type: select
> +__Choices: Wep/Open network, WPA PSK protected network

I suggest removing "network" in choices names

> +# :sl1:

That should probably be "sl2" as the feature is probably not meant to
be on the default installation path .

> +_Description: Wireless Network Type for ${iface}:
> + You have two choices for wireless network type. Chose Wep/Open if your
> + network is open or secured with wep. Chose WPA if your network is a
> + WPA PSK protected network.

No need to say "You have two choices" as it is obvious from the
presented choices....

I also recommend not using "your" network as the network might very
well not the the property of the user..:-)

Type: select
__Choices: Wep/Open network, WPA PSK protected network
# :sl2:
_Description: Wireless network type for ${iface}:
 Please choose the wireless network type. You should choose 'Wep/Open'
 if the network is opened or secured with a WEP key. You should choose
 'WPA PSK protected' for WPA-based protection.

Proposals for other templates:

Template: netcfg/invalid_pass
Type: error
# :sl2:
_Description: Invalid passphrase
 The WPA PSK passphrase is either too long (more than 64 characters)
 or too short (less than 8 characters).

Make this shorter and clearer.

Template: netcfg/wireless_wpa
Type: string
# :sl1:
_Description: WPA passphrase for wireless device ${iface}:

(I remove the "Please enter" which is really redundant for no reason)

Template: netcfg/no_wpa_supplicant
Type: error
# :sl2:
_Description: Wpasupplicant not found
 The wpa_supplicant binary was not found on the system.
 Please either choose WEP-based or opened wireless network, or
 wired network.

Template: netcfg/wifi_progress_info
Type: text
# :sl2:
_Description: Searching for wireless access points...

sublevel 2 seems OK to me

>  Template: netcfg/disable_dhcp
>  Type: boolean
> @@ -257,7 +287,7 @@
>  Type: text
>  # base-installer progress bar item
>  # :sl1:
> -_Description: Storing network settings...
> +_Description: Storing network settings ...

You introduce an unwanted change here.

Attachment: signature.asc
Description: Digital signature

Reply to: