[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: kernel 2.6.24 & speakup



Frans Pop, le Tue 25 Mar 2008 20:44:03 +0100, a écrit :
> > The idea is not to compile speakup built into the kernel, but just as a
> > module, and then it doesn't need to be integrated to the kernel build
> > system, 
> 
> Compiling it into the kernel is not what I'm talking about. It definitely 
> should be built as a module, but as it is part of the upstream kernel,

It is not part of the upstream kernel.

> > but just be compiled separately, just like exmap, ndiswrapper, spca5xx
> > etc. 
> 
> The reason they are in linux-modules extra is exactly because they are _not_ 
> included in the official upstream kernel source, and thus need to be in a 
> different source package.
> If you wanted speakup to be in linux-modules-extra, you should not have sent 
> your patches to lkml for inclusion...

Speakup didn't got to lkml for inclusion.  Only the notifier part did,
and it's now available in Debian.  The few still needed export symbols
didn't get through however, so a very light patch is still needed (see
attachement).

Samuel
diff --git a/drivers/char/consolemap.c b/drivers/char/consolemap.c
index 4b3916f..37c7980 100644
--- a/drivers/char/consolemap.c
+++ b/drivers/char/consolemap.c
@@ -277,6 +277,7 @@
 			return p->inverse_translations[m][glyph];
 	}
 }
+EXPORT_SYMBOL_GPL(inverse_translate);
 
 static void update_user_maps(void)
 {
--- a/drivers/char/keyboard.c
+++ b/drivers/char/keyboard.c
@@ -111,6 +111,8 @@
  
 struct kbd_struct kbd_table[MAX_NR_CONSOLES];
+EXPORT_SYMBOL_GPL(kbd_table);
 static struct kbd_struct *kbd = kbd_table;
+EXPORT_SYMBOL_GPL(kd_mksound);
 
 struct vt_spawn_console vt_spawn_con = {
 	.lock = __SPIN_LOCK_UNLOCKED(vt_spawn_con.lock),
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -3934,6 +3934,7 @@
 		c |= 0x100;
 	return c;
 }
+EXPORT_SYMBOL_GPL(screen_glyph);
 
 /* used by vcs - note the word offset */
 unsigned short *screen_pos(struct vc_data *vc, int w_offset, int viewed)

Reply to: