[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#346077: marked as done (busybox printf: support POSIX quoted-argument-character syntax)

Your message dated Mon, 24 Mar 2008 13:43:08 +0100
with message-id <200803241343.09894.thijs@debian.org>
and subject line fixed in recent busyboxes
has caused the Debian Bug report #346077,
regarding busybox printf: support POSIX quoted-argument-character syntax
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
346077: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=346077
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: busybox
Version: 1:1.01-3
Severity: wishlist
Tags: patch

POSIX documents [1] the following syntax for printf arguments:

  The argument operands shall be treated as strings if the corresponding
  conversion specifier is b, c, or s ; otherwise, it shall be evaluated
  as a C constant, as described by the ISO C standard, with the
  following extensions:

    [...]
    * If the leading character is a single-quote or double-quote, the
      value shall be the numeric value in the underlying codeset of the
      character following the single-quote or double-quote.

I found myself wanting this recently in order to convert non-devfs disk
device names into indices for display in partman (e.g. /dev/hde => "IDE2
master (hde)"). Lacking any other way to map from a-z to 0-25 in shell
that I can think of, it was going to have to be a messy sequence of sed
commands until somebody pointed out this syntax to me. With this patch,
I can just do:

  printf '%d\n' "'$character"

... to map from a-z to 0-25, which is much nicer. The small attached
patch implements this feature; I've checked it against the printf
implementation in coreutils.

[1] http://www.opengroup.org/onlinepubs/009695399/utilities/printf.html

Thanks,

-- 
Colin Watson                                       [cjwatson@debian.org]

--- busybox-1.01.orig/coreutils/printf.c
+++ busybox-1.01/coreutils/printf.c
@@ -281,7 +281,9 @@
 static unsigned long xstrtoul(char *arg)
 {
 	unsigned long result;
-	if (safe_strtoul(arg, &result))
+	if (*arg == '"' || *arg == '\'')
+		result = (unsigned char) *(arg + 1);
+	else if (safe_strtoul(arg, &result))
 		fprintf(stderr, "%s", arg);
 	return result;
 }
@@ -289,7 +291,9 @@
 static long xstrtol(char *arg)
 {
 	long result;
-	if (safe_strtol(arg, &result))
+	if (*arg == '"' || *arg == '\'')
+		result = (unsigned char) *(arg + 1);
+	else if (safe_strtol(arg, &result))
 		fprintf(stderr, "%s", arg);
 	return result;
 }
@@ -297,7 +301,9 @@
 static double xstrtod(char *arg)
 {
 	double result;
-	if (safe_strtod(arg, &result))
+	if (*arg == '"' || *arg == '\'')
+		result = (unsigned char) *(arg + 1);
+	else if (safe_strtod(arg, &result))
 		fprintf(stderr, "%s", arg);
 	return result;
 }

--- End Message ---
--- Begin Message --- 
Version: 1:1.9.2-1

Hi,

Recent busyboxes (at least the one in unstable, but well possibly older ones) 
incorporate this behaviour, so I'm closing the bug.


cheers,
Thijs

Attachment: pgpatVi3LUVbT.pgp
Description: PGP signature


--- End Message ---
Reply to: