[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#462396: Multiple disks support for partman-auto-lvm



Hi,

On Tuesday 19 February 2008, Grégory Oestreicher wrote:
> Le jeudi 24 janvier 2008 16:49, Frans Pop a écrit :
> > Attaching patch and especially the example recipes to ensure they
> > remain available. Recipes will be useful as documentation.
>
> Here is an updated patch that correct a bug when
> partman-auto-lvm/extra_devices is preseeded but none of them exist. This
> patch is against the SVN repository as of today (2008/02/19) and replaces
> the previous one.

Now that Beta1 is out I plan to look at your patch in detail soon.
I noticed the following change in the updated patch:

 +++ b/packages/partman/partman-auto-lvm/lib/auto-lvm.sh
[...]
-+                      if [ -d $tmpdevdir ]; then
++                      if [ -d "$tmpdevdir" ]; then
++                              echo "$tmpdevdir" >> /tmp/lvtest

What is the purpose of this last line? Or is that just something left over 
from your testing?

Cheers,
FJP



Reply to: