On Sunday 02 March 2008, Otavio Salvador wrote: > Frans Pop <elendil@planet.nl> writes: > > On Saturday 01 March 2008, Otavio Salvador wrote: > >> +# Check if a specific script should be used > >> +db_get base-installer/debootstrap_script > >> +DEBOOTSTRAP_SCRIPT="$RET" || true > > > > What's the point of the || true here? > > > > IMO the patch should test that the script exists and, if not, log the > > fact and either fail or unset the variable (maybe unless debootstrap > > itself already handles that case?). > > debootstrap fails if the script isn't available however I think it's a > great improvement to log it properly if it doesn't exist. I'll make > this change. You have not explained the '|| true'. Hint: AFAICT it's completely useless.
Attachment:
signature.asc
Description: This is a digitally signed message part.