[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New partman-multipath udeb



On Tue, Feb 26, 2008 at 05:11:51PM +0100, Frans Pop wrote:
> I saw that Otavio committed the multipath udeb. The indentation in various 
> scripts is a complete mess.
The indentation used spaces instead of tabs in several spaces, I cleaned
that up.

> Also, it looks like the finish-install script should be a base-installer 
> script (and should include what's in the finish.d script) as that would 
> remove the need to run update-initramfs again.
Could you point me to a package that does it like this?

> I'm fairly disappointed that this was just committed without a proper 
> review.
That certainly wasn't intended. Since this happened in separate package
there's hopefuly not too much harm done. 
Thanks for the review,
 -- Guido


Reply to: