[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#440439: Updated patch



On Tuesday 26 February 2008, Guido Günther wrote:
> attached is an updated patch for multipath detection in hw-detect. The
> patch hasn't changed it's just rediffed against current SVN.

This line is way to cryptic to my taste:
        [ -n "$(/sbin/multipath -l)" && $? ] && return 0 || return 1

Could you rewrite that to something that is a bit more intuitive?

Maybe:
if mplist=$(/sbin/multipath -l) && [ "$mplist" ]; then
	return 0
else
	return 1
fi

Also, is there a chance that 'multipath -l' will output to STDERR? If there 
is, that should either be redirected to /dev/null or logoutput should be 
used.

I have also fixed the indentation in that function to use tabs instead of 
spaces.

Cheers,
FJP



Reply to: