[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] libdebian-installer: add support for MIPS Malta

Thiemo Seufer <ths@networkno.de> writes:

> Otavio Salvador wrote:
>> Aurelien Jarno <aurelien@aurel32.net> writes:
>> > Otavio Salvador a écrit :
>> >> Aurelien Jarno <aurelien@aurel32.net> writes:
>> >> 
>> >>> +static struct cpu system_malta_cpu[] = {
>> >>                      system_mips_malta_cpu would be clearer, IMO.
>> >> 
>> >
>> > Well other names from the same file (which BTW has mips in its name)
>> > don't contain mips, that's why I did the same. But that can be changed.
>> Personally I think it would be easier for someone reading the code if
>> we put it there (and also fixes the missing ones). What others think
>> about it?
> I don't believe using redundant namespaces will help understanding.
> In worst case it adds more confusion about mips/mipsel. That's why
> I wrote the original code that way.

Sorry but I fail to see why it would be more confusing. But ok ...

        O T A V I O    S A L V A D O R
 E-mail: otavio@debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
"Microsoft sells you Windows ... Linux gives
 you the whole house."

Reply to: