On Friday 30 November 2007, dann frazier wrote: > The attached patch to di-utils adds a slightly modified version of I compiled this on amd64 and after stripping it is still 4k. As it is only needed during finish install, I wonder if it should be in di-utils and thus in initrds. Maybe we should create a di-utils-extra udeb that includes utils normally needed only after anna has been run. This could also include in-target for example. Not sure though. > Bryan's utility. This utility was originally called getserialdev - I've > renamed it to serial-console-info, since I think it better describes > the function. If I run the app on my system, I get an error code 255. It's probably correct that it returns an error, but I wonder if the value 255 is correct? > The attached patch to finish-install adds support for using > serial-console-info, if available, to 90console. Processing behaves > just as before, until it finds that /proc/<di-pid>/fd/0 is pointing at > /dev/console. It will only then run serial-console-info to see if it > can determine that /dev/console is actually a serial device. I think that, because of the "ttyS" assumption" this patch may break hvsi/hvc virtualized console support (bottom half of 90console). This should be checked. I don't think there's any need to write the output of s-c-i to a temp file. Just assigning it to a variable should work just as well: +if [ "$rawconsole" == "/dev/console" ] && \ + [ -x /bin/serial-console-info ] && \ + sci=$(/bin/serial-console-info); then + rawconsole="/dev/$(echo "$sci" | grep ^DEV= | cut -d= -f2)" + sci_baud=$(echo "$sci" | grep ^SPEED= | cut -d= -f2) +fi Cheers, FJP
Attachment:
signature.asc
Description: This is a digitally signed message part.