[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#405774: main-menu: should call free()



Package: main-menu
Version: 1.15
Severity: normal
Tags: d-i, patch

Hi.

in show_main_menu(), menu was allocated but it isn't freed.
I think it should be freed.

I attached a patch.
I made own d-i image with custom main-menu and did test it. it works fine.

Cheers,
-- 
/*
 * Masami Ichikawa
 * mailto: hangar-18@mub.biglobe.ne.jp
 *       : masami256@gmail.com
 */
--- main-menu-1.15/main-menu.c	2006-10-05 23:24:42.000000000 +0000
+++ main-menu.new/main-menu.c	2007-01-06 04:36:43.000000000 +0000
@@ -262,6 +262,7 @@
 		di_log(DI_LOG_LEVEL_WARNING, "Internal error! Cannot find \"%s\" in menu.", s);
 	}
 	
+	free(menu);
 	free(package_array);
 
 	return ret;

Reply to: