Re: [leonard.norrgard@refactor.fi: [Pkg-cryptsetup-devel] Bug#402417: handle chainmode/essiv "plain" correctly]

[David Härdeman <david@hardeman.nu>]

On Sat, Dec 30, 2006 at 04:46:27AM +0100, Jonas Meurer wrote:
> Hello,
>
> I need some advice regarding this bug. Unforuntately i don't know
> nothing about initramfs, and David Härdeman, the one who usually does
> all the cryptsetup initramfs stuff, is unavailable currently.
>
> Could somebody comment on this patch, so that the fix can make it into
> etch in case that it is ok?

I've done a quick check (and I wont have time to comment more until I 
return from my vacation):

1) renaming variables is a separate issue and should not be done

2) "-a" is a bashism so I think we should avoid it even though it seems to 
be supported by the initramfs shell

So just change the first check (around 240) from:

if [ -n "$blockcipher" ]; then

to

if [ -n "$blockcipher" ] && [ "$blockcipher" != "plain" ]; then

and the corresponding line (looks like line 244) from:

if [ -n "$ivhash" ]; then

to

if [ -n "$ivhash" ] && [ "$ivhash" != "plain" ]; then


That would reduce the patch volume to a two-line change with the same 
results. (And the patch looks sane to me btw so feel to do a new release 
with it applied)

Happy new year btw

--
David Härdeman