[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#452674: Patch looks okay



tags 452674 + patch
kthxbye

I know C pretty well (it's my best computer language), and the patch looks good to me. The only change I would make (and this is a minor nit) is to cache the result of strlen by putting it into a const size_t variable, which may improve the compiler's optimizations. But I think the patch works fine the way it is, although I haven't personally tested it.

--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 713 440 7475 | http://crustytoothpaste.ath.cx/~bmc | My opinion only
a typesetting engine: http://crustytoothpaste.ath.cx/~bmc/code/thwack
OpenPGP: RSA v4 4096b 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187

Attachment: signature.asc
Description: Digital signature


Reply to: