[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#440301: iso-scan.postinst fails to find ISO on partitioned USB stick



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Frans Pop <elendil@planet.nl> writes:

> So it *already should get this case* from explicitly using maybe-usb-floppy.
> What this patch does do, is potentially changing the behavior of the 
> rescue-mode postinst.

No. It's completely different:

#v+
1  <...>
2  syspaths=
3  case $TYPE in
4      partition)
5      for x in /sys/block/*/*; do
6          [ -d "$x" ] || continue
7          syspaths="${syspaths:+$syspaths }$x"
8      done
9      TYPE=disk
10     scan_partition=true
11     ;;
12     *)
13     for x in /sys/block/*; do
14         [ -d "$x" ] || continue
15         syspaths="${syspaths:+$syspaths }$x"
16     done
17     ;;
18 esac
19 for x in $syspaths; do
20 <...>
21     # Some USB sticks and CD drives are misdetected as floppy
22     # This allows to scan for those
23     if ! $match && ( $scan_partition || [ "$TYPE" = maybe-usb-floppy ] ); then
24         if udevinfo -q env -p "$devpath" 2>/dev/null | \
25            grep -q '^ID_BUS=usb' && \
26            udevinfo -q env -p "$devpath" 2>/dev/null | \
27            grep -q '^ID_TYPE=floppy'; then
28             match=:
29         fi
30     fi
31 <...>
32 done
#v-

At line 9 and 10 it set _how_ it ought to check the syspaths and the
set of paths is complely different between partition (line 4) and
normal case (line 12).

At line 23 I made it also check it for maybe misdetected usb devices,
in the only case we're using partition argument. So it doesn't looks
bogus to me.

- -- 
        O T A V I O    S A L V A D O R
- ---------------------------------------------
 E-mail: otavio@debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
- ---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8+ <http://mailcrypt.sourceforge.net/>

iD8DBQFHMOjBLqiZQEml+FURAvy+AJ0QF4yjLcRUzID9nl1VAVAzkrAhXgCguJj3
6hzed0DwphvWXDv/2xOnA7M=
=gK6m
-----END PGP SIGNATURE-----




Reply to: