Bug#447071: patches

[Steve Langasek <vorlon@debian.org>]

On Fri, Oct 19, 2007 at 04:34:24PM -0600, dann frazier wrote:

> > > Index: dhclient-script
> > > ===================================================================
> > > --- dhclient-script	(revision 49779)
> > > +++ dhclient-script	(working copy)
> > > @@ -89,6 +89,10 @@
> > >          # Get the domain name into a file suitable for netcfg to read.
> > >          echo -n "$new_domain_name" > /tmp/domain_name
> > >  
> > > +        if [ -n "$new_ntp_servers" ]; then
> > > +            echo -n "$new_ntp_servers" > /tmp/dhcp-ntp-servers
> > > +        fi
> > 
> > I'd probably use printf instead of echo -n although it will work in the
> > d-i environment.

> OK. Just for my benefit, what's the difference? I assume the 'echo -n'
> above my change should get changed as well?

printf is POSIX, echo -n is faux-POSIX. :)  (echo -n is explicitly listed in
Debian policy as an additional non-POSIX feature required from /bin/sh in
the installed system; that's not really a constraint for d-i, aside from
existing code that assumes its availability.)

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon@debian.org                                   http://www.debian.org/