[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#445157: debootstrap - hardcoded value of TARGET in second-stage prevents creation of a foreign chroot



On Tue, 16 Oct 2007 14:21:37 -0400
Joey Hess <joeyh@debian.org> wrote:

> Neil Williams wrote:
> > OK. I've done the doclifter thing and updated the XML, generated a new
> > manpage and compared it with the old. I'm assuming you don't want the
> > build-dependency on docbook-xsl so I've included a patch to create a
> > README that documents how to use xsltproc to generate the manpage.
> > (Note that the man page *diff* is larger than the entire XML file!)
> 
> Please don't ship files in the source that can be generated at build time.

Normally, I'd agree. In this case, I feel it is up to the maintainer to
decide whether to add a build dependency. Especially as it is my
complete inability to edit groff that led to the use of XML in the first
place.
:-)

> And finally, isn't just vi $manpage easier than all this?

Umm, no. I cannot edit groff - it makes about as much sense to me as
lisp or haskell. I stick to what I know, C, Perl, XML and autotools. I
just can't see the point of learning groff, just as I'd never try to
deal with bugs in python or C#.

Plus, the use of doclifter and xsltproc (using a stylesheet from
docbook-xsl) makes for a better looking manpage than I could ever hope
to achieve with vi. YMMV.

> Index: debootstrap.8
> ===================================================================
> --- debootstrap.8       (revision 49792)
> +++ debootstrap.8       (working copy)
> @@ -92,6 +92,10 @@
>  Complete the bootstrapping process. Other arguments are generally not
>  needed.
>  .IP
> +.IP "\fB\-\-second\-stage\-tarball DIR\fP"
> +Run second stage in a subdirectory instead of root. (can be used to create
> +a foreign chroot) (requires --second-stage)
> +.IP
>  .IP "\fB\-\-keep\-debootstrap\-dir\fP"
>  Don't delete the /debootstrap directory in the target after completing the
>  installation.
> -- 
> see shy jo

Sorry, Joey, I know you understand groff but I don't. I have no idea
where to start with all those \f commands.

All my manpages are built from XML using docbook-xsl as a
build-depends. Normally, I wouldn't have touched the manpage for this
bug but Otavio asked me to provide a patch and the XML process was
acceptable to him because it could make it easier for him to update
the manpage too, so that's what I have done.

Otavio: It's up to you if you want to dump README.diff and implement
that xsltproc rule in the build, adding docbook-xsl to build-depends in
the process. It's relatively painless and the best way overall, IMHO.

-- 


Neil Williams
=============
http://www.data-freedom.org/
http://www.nosoftwarepatents.com/
http://www.linux.codehelp.co.uk/

Attachment: pgpwNWDzC2xS1.pgp
Description: PGP signature


Reply to: