[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Setup of Romanian keymap for X

Hash: SHA1

# Christian was right
reassign 416544 xserver-xorg

Eddy Petrișor wrote:
> tags 416544 patch l10n
> thanks
> Christian Perrier wrote:
>> I think this probably belongs to xserver-xorg. The X keymap is set in
>> that package's postinst. In that piece of code, I see nothing to
>> properly handle Romanian keymaps (and, yes, this is ugly and not well
>> scalable):

> I'll test the attached patch and tell you about the results.

I fociblity purged the xserver-xorg package (1:7.1.0-15) installed and installed
1:7.1.0-15.1 (which only added the previous patch and a changelog entry - patch
attached), I installed all resulting packages from the build (except -dev
packages), including xserver-xorg.

Then I added a new user, restarted gdm and logged in with the new user. The
default keyboard layout was the romanian one.

(I think the next section deserves a bug of its own, but I'll let others judge

WRT the non-scalability, I agree and think we should add a step to the new
language process[1] that would add pairs like:


Which should define DI to Xorg layout mappings and we could add that info
directly as pacthes to xorg (or maybe console-data, or which is the
most-hip-console-layout-database) and xorg could use that information during
build to make the appropriate xserver-xorg.postinst section (of course, if added
to other package than xorg, xorg would have to Build-Depend on that package,
thus takign the most recent information).

What do you think?

[1] http://d-i.alioth.debian.org/i18n-doc/ch03.html

- --
"Imagination is more important than knowledge" A.Einstein
Version: GnuPG v1.4.6 (GNU/Linux)

diff -ruN xorg-7.1.0.unstable/debian/changelog xorg-7.1.0/debian/changelog
--- xorg-7.1.0.unstable/debian/changelog	2007-03-06 19:48:21.000000000 +0200
+++ xorg-7.1.0/debian/changelog	2007-03-29 14:54:39.000000000 +0300
@@ -1,3 +1,11 @@
+xorg (1:7.1.0-15.1) unstable; urgency=low
+  * Non-maintainer upload.
+  * inherit keyboard information selected in Debian Installer for the
+    Romanian keyboard (Closes: #416544)
+ -- Eddy PetriÈ?or <eddy.petrisor@gmail.com>  Thu, 29 Mar 2007 14:51:06 +0300
 xorg (1:7.1.0-15) unstable; urgency=low
   * Reupload without the .git/ dir.
diff -ruN xorg-7.1.0.unstable/debian/xserver-xorg.postinst.in xorg-7.1.0/debian/xserver-xorg.postinst.in
--- xorg-7.1.0.unstable/debian/xserver-xorg.postinst.in	2007-02-13 12:02:09.000000000 +0200
+++ xorg-7.1.0/debian/xserver-xorg.postinst.in	2007-03-29 14:34:17.000000000 +0300
@@ -1190,6 +1190,7 @@
     no) XMAP="no";;
     pl) XMAP="pl";;
     pt) XMAP="pt";;
+    ro) XMAP="ro";;
     uk) XMAP="gb";;
     lv-latin4) XMAP="lv";;
     se) XMAP="se";;

Reply to: