[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#401426: marked as done (partconf: useless defaults word in /etc/fstab)

Your message dated Wed, 31 Jan 2007 11:17:19 +0000
with message-id <E1HCDSp-0007Fm-IB@ries.debian.org>
and subject line Bug#401426: fixed in partconf 1.20
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: partconf
Version: 1.19
Severity: wishlist

The "defaults" word in /etc/fstab exist so that one has something to write
as a 4th field, but it's really useless if there are more options. In such
cases it may be removed safely.

In most cases, removing this extra word makes fstab more readable, as
fields 5 and 6 are closer to the same fields in previous and next lines.


proc            /proc           proc    defaults        0       0
/dev/hda5       /               ext3    defaults,errors=remount-ro 0       1
/dev/hda3       none            swap    sw              0       0


proc            /proc           proc    defaults        0       0
/dev/hda5       /               ext3    errors=remount-ro 0       1
/dev/hda3       none            swap    sw              0       0

Suggested patch:

diff -ru partconf-1.19.orig/mkfstab.c partconf-1.19/mkfstab.c
--- partconf-1.19.orig/mkfstab.c	2006-07-26 00:52:11.000000000 +0200
+++ partconf-1.19/mkfstab.c	2006-12-03 13:46:03.044507210 +0100
@@ -93,7 +93,7 @@
 	} else {
 		if((strcmp(dummy->mountpoint, "/") == 0) &&
 		  ((strcmp(dummy->typ, "ext2") == 0) || (strcmp(dummy->typ, "ext3") == 0))) {
-			dummy->options = strdup("defaults,errors=remount-ro");
+			dummy->options = strdup("errors=remount-ro");
 		} else {
 			dummy->options = strdup("defaults");


--- End Message ---
--- Begin Message ---
Source: partconf
Source-Version: 1.20

We believe that the bug you reported is fixed in the latest version of
partconf, which is due to be installed in the Debian FTP archive:

  to pool/main/p/partconf/partconf-find-partitions_1.20_amd64.udeb
  to pool/main/p/partconf/partconf-mkfstab_1.20_amd64.udeb
  to pool/main/p/partconf/partconf_1.20.dsc
  to pool/main/p/partconf/partconf_1.20.tar.gz

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 401426@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Frans Pop <fjp@debian.org> (supplier of updated partconf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Wed, 31 Jan 2007 11:52:28 +0100
Source: partconf
Binary: partconf-mkfstab partconf-find-partitions partconf
Architecture: source amd64
Version: 1.20
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Frans Pop <fjp@debian.org>
 partconf-find-partitions - debian-installer utility for finding partitions (udeb)
 partconf-mkfstab - debian-installer utility for creating fstab file (udeb)
Closes: 401426
 partconf (1.20) unstable; urgency=low
   * Remove Thorsten Sauter from uploaders as requested by MIA team.
   * Apply patch from Santiago Vila that removes redundant 'defaults' in fstab.
     Closes: #401426.
   * Add myself to uploaders.
   [ Updated translations ]
   * Arabic (ar.po) by Ossama M. Khayat
   * Belarusian (be.po) by Pavel Piatruk
   * Bulgarian (bg.po) by Damyan Ivanov
   * Bengali (bn.po) by Jamil Ahmed
   * Bosnian (bs.po) by Safir Secerovic
   * Catalan (ca.po) by Jordi Mallach
   * Czech (cs.po) by Miroslav Kure
   * Danish (da.po) by Claus Hindsgaul
   * German (de.po) by Jens Seidel
   * Esperanto (eo.po) by Serge Leblanc
   * Spanish (es.po) by Javier Fernández-Sanguino Peña
   * Estonian (et.po) by Siim Põder
   * Basque (eu.po) by Piarres Beobide
   * French (fr.po) by Christian Perrier
   * Galician (gl.po) by Jacobo Tarrio
   * Hungarian (hu.po) by SZERVÃ?C Attila
   * Georgian (ka.po) by Aiet Kolkhi
   * Kurdish (ku.po) by Amed Ã?eko Jiyan
   * Latvian (lv.po) by Aigars Mahinovs
   * Malayalam (ml.po) by Praveen A
   * Norwegian Bokmål (nb.po) by Bjørn Steensrud
   * Dutch (nl.po) by Bart Cornelis
   * Norwegian Nynorsk (nn.po) by HÃ¥vard Korsvoll
   * Panjabi (pa.po) by A S Alam
   * Polish (pl.po) by Bartosz Fenski
   * Portuguese (Brazil) (pt_BR.po) by Felipe Augusto van de Wiel (faw)
   * Portuguese (pt.po) by Miguel Figueiredo
   * Romanian (ro.po) by Eddy PetriÈ?or
   * Russian (ru.po) by Yuri Kozlov
   * Slovak (sk.po) by Peter Mann
   * Slovenian (sl.po) by Matej KovaÄ?iÄ?
   * Swedish (sv.po) by Daniel Nylander
   * Tamil (ta.po) by drtvasudevan
   * Thai (th.po) by Theppitak Karoonboonyanan
   * Tagalog (tl.po) by Eric Pareja
   * Ukrainian (uk.po) by Eugeniy Meshcheryakov
 7e745d9c19f516480f81305676d76cef 792 debian-installer standard partconf_1.20.dsc
 0d4627fec2153a5e84ffdc7d8788d783 115179 debian-installer standard partconf_1.20.tar.gz
 f2cb07193948d5f90058aa4f273c58a9 6492 debian-installer optional partconf-find-partitions_1.20_amd64.udeb
 aca7dc3f0910eb40fa569b5322823028 6174 debian-installer optional partconf-mkfstab_1.20_amd64.udeb
Package-Type: udeb

Version: GnuPG v1.4.6 (GNU/Linux)


--- End Message ---

Reply to: