[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#405774: marked as done (main-menu: should call free())

Your message dated Sat, 06 Jan 2007 10:17:04 +0000
with message-id <E1H38bo-0001Mc-Vv@ries.debian.org>
and subject line Bug#405774: fixed in main-menu 1.16
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: main-menu
Version: 1.15
Severity: normal
Tags: d-i, patch


in show_main_menu(), menu was allocated but it isn't freed.
I think it should be freed.

I attached a patch.
I made own d-i image with custom main-menu and did test it. it works fine.

 * Masami Ichikawa
 * mailto: hangar-18@mub.biglobe.ne.jp
 *       : masami256@gmail.com
--- main-menu-1.15/main-menu.c	2006-10-05 23:24:42.000000000 +0000
+++ main-menu.new/main-menu.c	2007-01-06 04:36:43.000000000 +0000
@@ -262,6 +262,7 @@
 		di_log(DI_LOG_LEVEL_WARNING, "Internal error! Cannot find \"%s\" in menu.", s);
+	free(menu);
 	return ret;

--- End Message ---
--- Begin Message ---
Source: main-menu
Source-Version: 1.16

We believe that the bug you reported is fixed in the latest version of
main-menu, which is due to be installed in the Debian FTP archive:

  to pool/main/m/main-menu/main-menu_1.16.dsc
  to pool/main/m/main-menu/main-menu_1.16.tar.gz
  to pool/main/m/main-menu/main-menu_1.16_amd64.udeb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 405774@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Frans Pop <fjp@debian.org> (supplier of updated main-menu package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Sat,  6 Jan 2007 10:29:01 +0100
Source: main-menu
Binary: main-menu
Architecture: source amd64
Version: 1.16
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Frans Pop <fjp@debian.org>
 main-menu  - Debian installer main menu (udeb)
Closes: 405774
 main-menu (1.16) unstable; urgency=low
   * show_main_menu: free menu variable after use. Closes: #405774.
     Thanks to Masami Ichikawa who spotted the error.
   * Add myself to uploaders.
   [ Updated translations ]
   * Arabic (ar.po) by Ossama M. Khayat
   * Belarusian (be.po) by Pavel Piatruk
   * Bulgarian (bg.po) by Damyan Ivanov
   * Bosnian (bs.po) by Safir Secerovic
   * Danish (da.po) by Claus Hindsgaul
   * Georgian (ka.po) by Aiet Kolkhi
   * Kurdish (ku.po) by Amed Ã?eko Jiyan
   * Latvian (lv.po) by Aigars Mahinovs
   * Malayalam (ml.po) by Praveen A
   * Norwegian Nynorsk (nn.po) by HÃ¥vard Korsvoll
   * Panjabi (pa.po) by A S Alam
   * Portuguese (Brazil) (pt_BR.po) by Felipe Augusto van de Wiel (faw)
   * Russian (ru.po) by Yuri Kozlov
   * Tagalog (tl.po) by Eric Pareja
 edc8ca44f89a5af1613c9fe20fddd0e6 840 debian-installer standard main-menu_1.16.dsc
 a7e1643fb6bf883f4bcc042e4d21c495 44686 debian-installer standard main-menu_1.16.tar.gz
 3a472bf24fb0e86b2f213ed5fad4ab21 21850 debian-installer standard main-menu_1.16_amd64.udeb
Package-Type: udeb

Version: GnuPG v1.4.6 (GNU/Linux)


--- End Message ---

Reply to: