[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#405102: installation-report: Include info on which PCI device is in used by which kernel module



Hi Petter,

Not yet tested the patch, but the idea looks nice.

On Sunday 31 December 2006 11:14, Petter Reinholdtsen wrote:
> +		if grep -q "^$module " /proc/modules ; then
> +		    address=$(echo $address |sed s/0000://)
> +		    echo "`lspci -n -s $address | tail -n 1 | awk '{print $3}'` $module"

This should be '$lspci', right?

Some minor comments:
- please always use tab indentation in d-i (saves memory)
- we slightly prefer '$(...)' over '`...`'.

Cheers,
FJP

Note to self and joeyh;
Is the check for /target//usr/bin/lspci still useful now that lspci
is no longer installed by default?
I suspect that the chance of it not being available in d-i environment
but somehow installed in /target is very close to zero.

Attachment: pgpfGGSwyNe4B.pgp
Description: PGP signature


Reply to: