[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#403820: debian-installer-utils: user-params shouldn't pass brltty option



Package: debian-installer-utils
Version: 1.41
Severity: normal
Tags: patch

Hi,

user-params passes options given to the installer kernel so that grub
has them too.

However, in the case of the brltty option, this shouldn't be done,
because the brltty-udeb package scripts already pass these options into
/target/etc/brltty.conf.  Worse than that actually, the grub options
would take precedence over the brltty.conf options, so that the user
ends up with a no-effect configuration file.

So user-params should not pass the brltty= option, the joined working
patch fixes that.

Samuel

-- System Information:
Debian Release: 4.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.19
Locale: LANG=fr_FR@euro, LC_CTYPE=fr_FR@euro (charmap=ISO-8859-15)
--- debian-installer-utils-1.41/user-params	2006-11-22 11:51:03.000000000 +0100
+++ debian-installer-utils-1.41-mine/user-params	2006-12-19 23:22:00.000000000 +0100
@@ -13,6 +13,12 @@
 		continue
 	fi
 
+	# brltty settings shouldn't be passed since
+	# they are already recorded in /etc/brltty.conf
+	if [ "$var" = brltty ]; then
+		continue
+	fi
+
 	# Skip debconf variables.
 	varnoslash="${var##*/*}"
 	if [ "$varnoslash" = "" ]; then

Reply to: