[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#402661: marked as done (SELECT handler crashes when the default option is present multiple times)

Your message dated Sat, 16 Dec 2006 17:17:02 +0000
with message-id <E1Gvd9i-0005Tp-UO@ries.debian.org>
and subject line Bug#402661: fixed in cdebconf 0.111
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
package: cdebconf-gtk-udeb
severity: normal
tags: patch

Suppose a SELECT question has options

mickey
goofy
donald
goofy
and goofy (present twice in the options list) is the default option: you'll get a crash under directfb and a warning under x11 as soon as the question gets displayed. The crash is avoidable by adding with an extra check on the flag variable that indicates whether the default option was already found or not. Usually you don't have twice the same option in a SELECT question, but anyway i think this bug has to be fixed ASAP. 

cheers

Attilio

Index: gtk.c
===================================================================
--- gtk.c	(revisione 43298)
+++ gtk.c	(copia locale)
@@ -964,7 +964,7 @@
     {
         gtk_list_store_append (store, &iter);
         gtk_list_store_set (store, &iter, SELECT_COL_NAME, choices_translated[i], -1);
-        if (defval && strcmp(choices[tindex[i]], defval) == 0)
+        if (!flag_default_set && defval && strcmp(choices[tindex[i]], defval) == 0)
         {
             expose_data -> path = gtk_tree_path_to_string (gtk_tree_model_get_path (model, &iter));
             expose_data -> callback_function = g_signal_connect_after (G_OBJECT(view), "expose_event", G_CALLBACK (treeview_exposed_callback), (gpointer) expose_data);
@@ -1073,7 +1073,7 @@
                 gtk_tree_store_append (store, &child, &iter);
                 gtk_tree_store_set (store, &child, SELECT_COL_NAME, choices_translated[i], -1);
 
-                if (defval && strcmp(choices[tindex[i]], defval) == 0)
+                if (!flag_default_set && defval && strcmp(choices[tindex[i]], defval) == 0)
                 {
                     gtk_tree_view_expand_row (GTK_TREE_VIEW (view), gtk_tree_model_get_path (model, &iter), TRUE);
                     expose_data -> path = gtk_tree_path_to_string (gtk_tree_model_get_path (model, &child));
@@ -1089,7 +1089,7 @@
                 gtk_tree_store_append (store, &child, &iter);
                 gtk_tree_store_set (store, &child, SELECT_COL_NAME, choices_translated[i], -1);
                 gtk_tree_view_expand_row (GTK_TREE_VIEW(view), gtk_tree_model_get_path(model, &iter), TRUE);
-                if (defval && strcmp(choices[tindex[i]], defval) == 0)
+                if (!flag_default_set && defval && strcmp(choices[tindex[i]], defval) == 0)
                 {
                     expose_data -> path = gtk_tree_path_to_string (gtk_tree_model_get_path (model, &child));
                     expose_data -> callback_function = g_signal_connect_after (G_OBJECT(view), "expose_event", G_CALLBACK (treeview_exposed_callback), (gpointer) expose_data);
@@ -1100,7 +1100,7 @@
             {    /* father, disk */
                 gtk_tree_store_append (store, &iter,NULL);
                 gtk_tree_store_set (store, &iter, SELECT_COL_NAME, choices_translated[i], -1);
-                if (defval && strcmp(choices[tindex[i]], defval) == 0)
+                if (!flag_default_set && defval && strcmp(choices[tindex[i]], defval) == 0)
                 {
                     expose_data -> path = gtk_tree_path_to_string (gtk_tree_model_get_path (model, &iter));
                     expose_data -> callback_function = g_signal_connect_after (G_OBJECT(view), "expose_event", G_CALLBACK (treeview_exposed_callback), (gpointer) expose_data);

--- End Message ---
--- Begin Message --- 
Source: cdebconf
Source-Version: 0.111

We believe that the bug you reported is fixed in the latest version of
cdebconf, which is due to be installed in the Debian FTP archive:

cdebconf-gtk-udeb_0.111_i386.udeb
  to pool/main/c/cdebconf/cdebconf-gtk-udeb_0.111_i386.udeb
cdebconf-newt-udeb_0.111_i386.udeb
  to pool/main/c/cdebconf/cdebconf-newt-udeb_0.111_i386.udeb
cdebconf-priority_0.111_all.udeb
  to pool/main/c/cdebconf/cdebconf-priority_0.111_all.udeb
cdebconf-text-udeb_0.111_i386.udeb
  to pool/main/c/cdebconf/cdebconf-text-udeb_0.111_i386.udeb
cdebconf-udeb_0.111_i386.udeb
  to pool/main/c/cdebconf/cdebconf-udeb_0.111_i386.udeb
cdebconf_0.111.dsc
  to pool/main/c/cdebconf/cdebconf_0.111.dsc
cdebconf_0.111.tar.gz
  to pool/main/c/cdebconf/cdebconf_0.111.tar.gz
cdebconf_0.111_i386.deb
  to pool/main/c/cdebconf/cdebconf_0.111_i386.deb
libdebconfclient0-dev_0.111_i386.deb
  to pool/main/c/cdebconf/libdebconfclient0-dev_0.111_i386.deb
libdebconfclient0-udeb_0.111_i386.udeb
  to pool/main/c/cdebconf/libdebconfclient0-udeb_0.111_i386.udeb
libdebconfclient0_0.111_i386.deb
  to pool/main/c/cdebconf/libdebconfclient0_0.111_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 402661@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Frans Pop <fjp@debian.org> (supplier of updated cdebconf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 16 Dec 2006 17:57:12 +0100
Source: cdebconf
Binary: cdebconf-slang-udeb libdebconfclient0 cdebconf-priority cdebconf libdebconfclient0-dev cdebconf-udeb libdebconfclient0-udeb cdebconf-gtk-udeb cdebconf-text-udeb cdebconf-newt-udeb
Architecture: source i386 all
Version: 0.111
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Frans Pop <fjp@debian.org>
Description: 
 cdebconf   - Debian Configuration Management System (C-implementation)
 cdebconf-gtk-udeb - Gtk+ frontend for Debian Configuration Management System (udeb)
 cdebconf-newt-udeb - Newt frontend for Debian Configuration Management System (udeb)
 cdebconf-priority - Change debconf priority (udeb)
 cdebconf-text-udeb - Plain text frontend for Debian Configuration Management System (udeb)
 cdebconf-udeb - Debian Configuration Management System (C-implementation) (udeb)
 libdebconfclient0 - Debian Configuration Management System (C-implementation)
 libdebconfclient0-dev - Development files for cdebconf
 libdebconfclient0-udeb - Debian Configuration Management System (C-implementation) (udeb)
Closes: 402661
Changes: 
 cdebconf (0.111) unstable; urgency=low
 .
   [ Attilio Fiandrotti ]
   * For SELECT handlers, properly manage those cases where the default option
     exists multiple times. Closes: #402661.
   * Only set the title of questions and progress bars once; reset the title of
     a progress bar after a question has been asked while one is running.
Files: 
 7ec8ea57a15198b26c6d86af10783241 1178 utils optional cdebconf_0.111.dsc
 ba1d04b9c5a580dc0eef492e83aa5fb8 236846 utils optional cdebconf_0.111.tar.gz
 6a441a3d4da3aaad8f8d4af926a8447c 2678 debian-installer standard cdebconf-priority_0.111_all.udeb
 8954ee4c987916a515a83b213a5579b2 147930 utils extra cdebconf_0.111_i386.deb
 ca54e921ecbcecc46171dfc65e630d8b 32230 libs optional libdebconfclient0_0.111_i386.deb
 08cc8030df9e02712e11ff9c6a811455 33630 libdevel optional libdebconfclient0-dev_0.111_i386.deb
 231961bd5d1256da2a3f944284da1061 68584 debian-installer standard cdebconf-udeb_0.111_i386.udeb
 2bf72ed5a0e7a2b1a36a7ed1ac3c4d52 2998 debian-installer optional libdebconfclient0-udeb_0.111_i386.udeb
 3836bdc733b04999d0ccf97197f676e9 16790 debian-installer optional cdebconf-newt-udeb_0.111_i386.udeb
 91e238849a7d1ff2f9bbeac7917a424d 18130 debian-installer optional cdebconf-text-udeb_0.111_i386.udeb
 1bf6b192f4f3a19a94ed86bbf89f07aa 22882 debian-installer optional cdebconf-gtk-udeb_0.111_i386.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFFhCfYgm/Kwh6ICoQRAmY/AKC0U3J31PFg5uJ4QEsMAywHnkWdFACgoPcM
waGvCYk5F3bS5KkZnzyTHo4=
=pmMn
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: