[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#402127: GTK frontend should build on and X target too


On Fri, Dec 08, 2006, Attilio Fiandrotti wrote:
> This patch is needed to build cdebconf's GTK frontend in an X11 
> environment; i'm using GDK_WINDOWING_X11 as GDK_WINDOWING_DIRECTFB is 
> currently not available in GTKDFB 2.8.20.

 I don't understand why it's useful for the udeb, isn't the udeb always
 runnong atop of directfb?

> - It's necessary if one wants to replace debconf with cdebconf on a 
> regular debian system (it's a blocker for #328498)
> -It's useful to test the GTK frontend on top of X11

 The problems you describe are not obvious to me, I currently only see a
 udeb providing cdebconf-gtk.  IIUC, cdebconf-gtk-udeb will always be
 built against gtk/directfb and perhaps a future new package named
 cdebconf-gtk will be built against gtk/x11.

> I guess we'll also have to provide cdebconf's build system with a switch 
> that allows building the directfb or x11 flavuor of the GTK frontend.

 I think you will have to build twice cdebconf's gtk files, with
 different CFLAGS, like gtk2-engines.

> Loic, could you please check if this patch is ok?
> -#if GTK_CHECK_VERSION(2,10,0)
> +#ifndef GDK_WINDOWING_X11
>  #include <directfb.h>
>  #endif
> -#else
> -#include <directfb.h>
> -#endif

 Bah, I think you're working around the fact that the gtk/directfb
 headers are not available in gtk 2.8; perhaps you can simply pass
 -DGDK_WINDOWING_DIRECTFB in your CFLAGS to force the build against
 gtk/x11?  Both solutions are IMO ugly.  Did you check Gtk 2.10's
 headers?  These are split and you can either build against pure
 directfb or pure x11, and there are even .pc files.  You can probably
 achieve a build against x11 or directfb by simply setting
 PKG_CONFIG_PATH since the gtk module uses pkg-config.

 Since this all sounds like post-etch stuff, and since I think there's a
 clean solution for Gtk 2.10, I'm not sure the patch is needed.

PS: if you use X-Debbugs-Cc instead of Cc:, I get the bug number
Loïc Minier <lool@dooz.org>
 "I have no strong feelings one way or the other." -- Neutral President

Reply to: