Re: Bug#394971: [powerpc64] load the fan control modules
Sven Luther <sven.luther@wanadoo.fr> writes:
>> Also, I wonder if all listed modules really need to be modprobed
>> individually: modprobe will after all load modules that other modules
>> depend on automatically.
>
> Well, this is not how things are, after investigation and discussion with
> Benjamin Herrenschmidt, the powerpc/powermac linux kernel maintainer. The
> current way of doing this is the best compromise for within the 2.6.18 and
> etch timeframe.
What's the plan for lenny? Is it going to change on 2.6.19 or so?
>> I would expect that i2c-powermac and windfarm_core can safely be dropped.
>
> And you would expect wrong. When are you going to stop to try to second guess
> the work and investigation i do, and try by all mean to show me as incapable ?
Hold on Sven... I need to agree here with Frans. We always should try
to reduce the amount of code and looks like there's a lot of dependent
module being loaded by hand in your patch. If it has a reason, it's ok
but you need to tell us about it.
It's impossible to you, Frans or everyone to know about everything on
every arch so as a D-I RM Frans did a question and I think you can
just reply to it as I usually do and many others does too. There's no
try to show you as incapable person.
> They cannot be dropped, especially i2c-powermac cannot be dropped, since it
> will not be pulled in by the other modules. There are numerous comments about
> this fact on both debian-kernel and debian-powerpc, as well as numerous irc
> conversations on debian-kernel, where you are also present.
Isn't it a bug that could be solve on kernel itself?
> So, either you chose to get involved, and try to stay informed about the
> different powerpc developments, or you don't, but then it is only fair to ask
> you to trust my knowledge and competence, as well as the interaction with the
> upstream linux/powerpc community such as Benjamin Herrenschmidt. Your current
> attitude is quite insulting to them and me, please modify it.
Please modify your action too.
As you know I worry about ppc status and try to be updated about
it. I'm still lacking the need hardware to work on it but it should
change in near future and I'll get more involviment on it as I did
before when I had an iBook. Besides, we all do mistake and you aren't
different.
We should try to review our code and patches to ensure a high quality
on d-i and it should be done when the patches are pending to be
commited as Frans is doing now. Please calm down and just reply for
the questions and then I'm sure Frans will commit the patch also
because it's really need for a proper ppc support from d-i side.
>> Finally, why was S50directfb-linux-powerpc added in the Makefile? This
>> seems unrelated to this patch.
>
> It was not. Or should not have been. If it was, it is uniquely a result of a
> bad manipulation caused by me not having the svn commit right, and you are as
> thus solely to blame for it.
>
> But seriously, find attached my svn diff, there is no trace of a
> S50directfb-linux-powerpc in my diff, if it was there, it most probably did
> come from an older commit. I did in fact do an apt-get source of rootskel, and
> then applied the svn diff output, so i have no idea where this
> S50directfb-linux-powerpc file came from. I guess it came from earlier
> experiments done while me and attilio and a few others tried to investigate
> the g-i breakage.
Yes, it was include in your patch and might be useful if you can send
a revised patch fixing the modprobe syntax and removing this hook
from it.
>> Colin suggested that when we apply this patch in the installer, a similar
>> patch should added in initramfs-tools to make sure that the modules are
>> loaded too on the installed system. Has that already been coordinated?
>
> A similar patch for therm_pm72 is already in the installer, and i have
> regularly been pushing maks to apply the whole stuff, but without success upto
> now.
Let me ask it here again. Doesn't the right place to fix it be the
kernel? Is too difficult to fix it there?
Friendly ;-)
Otavio Salvador
--
O T A V I O S A L V A D O R
---------------------------------------------
E-mail: otavio@debian.org UIN: 5906116
GNU/Linux User: 239058 GPG ID: 49A5F855
Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft gives you Windows ... Linux gives
you the whole house."
Reply to: