[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#396116: localechooser: Please set English as fallback language for floppy installations



tags 396116 patch
thanks

Quoting Frans Pop (elendil@planet.nl):
> Package: localechooser
> Version: 1.29
> Severity: important
> 
> When I select Dutch during a floppy based install, I get keymap codes 
> instead of names. I suspect the reason for this is that when building 
> floppies, all translations except English are filtered out to conserve 
> space and the Dutch language does not have English set as a fall back 
> language anymore.
> 
> So, to allow floppy based installations to show keymaps, it would be 
> nice if English could be added as fallback language for all other 
> languages.
> This could be done either in the languagelist, or on the fly in the 
> localechooser script.


I did choose the "on the fly" solution.

See attached patch which I prefer to get reviewed in order to correct
the shell script programming "à la Christian" which you all know
about..:-)

The point is "if the language list doesn't already include English,
then we add it at the end"

-- 




--- localechooser.ori	2006-10-30 18:44:53.434187124 +0100
+++ localechooser	2006-10-30 18:56:11.586749132 +0100
@@ -486,6 +486,17 @@
 fi
 
 
+# The code below adds "en" at the end of the language list
+# This wil guarantee that English is always a fallback language
+# See #396116
+if ! echo "$LANGUAGELIST" | grep -q "en" ; then
+	LANGUAGELIST=${LANGUAGELIST}:en
+	# Languagelist setting
+	db_set "$languagecode" "$LANGUAGELIST"
+	log "Set $languagecode = '$LANGUAGELIST'"
+fi
+
+
 # SELECT ADDITIONAL LOCALES
 
 # We will select from supported locales

Attachment: signature.asc
Description: Digital signature


Reply to: