Bug#391356: tasksel: support debconf-apt-progress for task scripts

[Colin Watson <cjwatson@ubuntu.com>]

On Sat, Oct 07, 2006 at 01:48:13PM -0400, Joey Hess wrote:
> Colin Watson wrote:
> > +# We also install the X server early on so that other packages (e.g.
> > +# usplash) can get at the resolution it configures.
> > +for pkg in discover1 xresprobe xserver-xorg; do
> 
> I don't see anything in usplash 0.3e that uses resolution data from
> xorg.

The comment may be wrong for Debian, then (and adding xserver-xorg to
desktop.preinst won't be necessary). Ubuntu's usplash 0.4-31 does:

        if  db_get xserver-xorg/config/display/modes; then
          FIRSTVAL=`echo $RET | sed 's/,.*//'`
          x=`echo $FIRSTVAL | sed 's/x.*//'`
          y=`echo $FIRSTVAL | sed 's/.*x//'`
        else
          x=640;
          y=480;
        fi
        echo "# Usplash configuration file" >/etc/usplash.conf
        echo "xres=$x" >>/etc/usplash.conf
        echo "yres=$y" >>/etc/usplash.conf

(The db_get should be replaced with parsing /etc/X11/xorg.conf; I
haven't got round to this yet.)

> Using data from another package without depending on it is aweful and
> not something we should encourage.

Well, it's optional in the case of usplash, and it has to be optional
because a splash screen should not depend on an X server being
installed. The use of data is there because X's resolution detection is
complicated enough that reimplementing it in another place is a bad
idea. I'm not sure how to do this any better at present.

> The rest of the patch seems workable, although quite ugly in places.

Yes, I wasn't happy with it as far as elegance goes; I went through
several iterations of the code for subdividing the progress bar before
settling on this layout. Anything in particular you'd like me to change?

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]