partman-auto bug for multiple disks
partman-auto has been changed now to deal with multiple disks for other
methods but it's broken:
case "$method" in
regular)
for disk in $disks; do
id=$(dev_to_partman "$disk") || true
if [ -n "$id" ]; then
autopartition "$id"
exit 0
fi
done
exit 1
;;
The exit 0 should be outside the for loop I think. In fact I would
propose the following patch but I'd like David/Frans to comment on it
before I just apply it.
--- initial_auto.orig 2006-10-04 12:31:18.000000000 +0100
+++ initial_auto 2006-10-04 12:31:39.000000000 +0100
@@ -55,10 +55,9 @@
id=$(dev_to_partman "$disk") || true
if [ -n "$id" ]; then
autopartition "$id"
- exit 0
fi
done
- exit 1
+ exit 0
;;
lvm)
search-path autopartition-lvm || exit 1
@@ -66,10 +65,9 @@
id=$(dev_to_partman "$disk") || true
if [ -n "$id" ]; then
autopartition-lvm "$id"
- exit 0
fi
done
- exit 1
+ exit 0
;;
crypto)
search-path autopartition-crypto || exit 1
@@ -77,10 +75,9 @@
id=$(dev_to_partman "$disk") || true
if [ -n "$id" ]; then
autopartition-crypto "$id"
- exit 0
fi
done
- exit 1
+ exit 0
;;
*)
# Unsupported method
--
_ huggie@earth.li -+*+- fou, con et anglais _
(_) "No problem is too big it can't be run away from" -- Linus (_)
(_) (_)
\___ ___/
Reply to: