[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Releasing G-I with RC1 - one RC issue remaining

Frans Pop wrote:
Hi Attilio,

With the new GTK 2.8 upload by Loïc [1] and the changes in keymap support, we now have only one RC problem remaining in G-I: the disappearing text on the current line in multi-select lists.

I do not think that 2.10 will be in unstable in time for the RC1 release, so it would be great if this issue could be solved in the current 2.8 libs.

Is there any way that you could backport the fix for this from 2.10?

Yesterday i attempted a backport from HEAD dfb backend to 2.8.20, but i failed as many parts of code have changed since may and the backport is now much more complicated. In the case of an update to the old backport i still need to understand where to look to fix the missing lines bug. Anyway, yesterday i eventually found the root of the "boom" bug [1] (it's in GTK or GLib) and, while waiting for someone to fix it, the below patch seems to workaround this issue in most cases. Loic, do you feel to try building a patched GTK 2.10.4 udeb so that frans can test if the "boom" bug is fixed?



[1] http://bugzilla.gnome.org/show_bug.cgi?id=357611

Index: gtk/gtkselection.c
RCS file: /cvs/gnome/gtk+/gtk/gtkselection.c,v
retrieving revision 1.110
diff -u -r1.110 gtkselection.c
--- gtk/gtkselection.c  6 Jul 2006 05:14:02 -0000       1.110
+++ gtk/gtkselection.c  26 Sep 2006 19:25:30 -0000
@@ -617,10 +617,10 @@

   g_return_if_fail (targets == NULL || n_targets > 0);

-  for (i = 0; i < n_targets; i++)
-    g_free (targets[i].target);
+//  for (i = 0; i < n_targets; i++)
+//    g_free (targets[i].target);

-  g_free (targets);
+//  g_free (targets);


Reply to: