[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#386752: marked as done (cdebconf-gtk-udeb: Probably not enough memory allocated for string)

Your message dated Sun, 24 Sep 2006 06:17:10 -0700
with message-id <E1GRTr4-0003DH-Jd@spohr.debian.org>
and subject line Bug#386752: fixed in cdebconf 0.106
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: cdebconf-gtk-udeb
Version: 0.105
Severity: normal
Tags: patch

I had a look at frontend/gtk/gtk.c and think that in
expose_event_callback() the argument to malloc() (line 244) is to
small. In the following line the sprintf() does not only use "<b></b>"
but "<b><span foreground="#ffffff"></span></b>". So I suppose there
should be room for 34 characters more.

--- gtk.c.orig	2006-06-15 15:31:08.000000000 +0200
+++ gtk.c	2006-09-09 22:58:00.000000000 +0200
@@ -241,7 +241,11 @@
     if (obj->info != NULL) {
         char *text = q_get_description(obj->info);
         if (text) {
+            #if GTK_CHECK_VERSION(2,8,0)
+            message = malloc(strlen(text) + 42 );
+            #else
             message = malloc(strlen(text) + 8 );
+            #endif
             /* TODO */
             /* setting custom font colours would make GTKDFB 2.0.9 crash */
             /* this issue has already been fixed in recent GTKDFB verions */

--- End Message ---
--- Begin Message ---
Source: cdebconf
Source-Version: 0.106

We believe that the bug you reported is fixed in the latest version of
cdebconf, which is due to be installed in the Debian FTP archive:

  to pool/main/c/cdebconf/cdebconf-gtk-udeb_0.106_i386.udeb
  to pool/main/c/cdebconf/cdebconf-newt-udeb_0.106_i386.udeb
  to pool/main/c/cdebconf/cdebconf-priority_0.106_all.udeb
  to pool/main/c/cdebconf/cdebconf-text-udeb_0.106_i386.udeb
  to pool/main/c/cdebconf/cdebconf-udeb_0.106_i386.udeb
  to pool/main/c/cdebconf/cdebconf_0.106.dsc
  to pool/main/c/cdebconf/cdebconf_0.106.tar.gz
  to pool/main/c/cdebconf/cdebconf_0.106_i386.deb
  to pool/main/c/cdebconf/libdebconfclient0-dev_0.106_i386.deb
  to pool/main/c/cdebconf/libdebconfclient0-udeb_0.106_i386.udeb
  to pool/main/c/cdebconf/libdebconfclient0_0.106_i386.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 386752@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Frans Pop <fjp@debian.org> (supplier of updated cdebconf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Sun, 24 Sep 2006 15:08:33 +0200
Source: cdebconf
Binary: cdebconf-slang-udeb libdebconfclient0 cdebconf-priority cdebconf libdebconfclient0-dev cdebconf-udeb libdebconfclient0-udeb cdebconf-gtk-udeb cdebconf-text-udeb cdebconf-newt-udeb
Architecture: source i386 all
Version: 0.106
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Frans Pop <fjp@debian.org>
 cdebconf   - Debian Configuration Management System (C-implementation)
 cdebconf-gtk-udeb - Gtk+ frontend for Debian Configuration Management System (udeb)
 cdebconf-newt-udeb - Newt frontend for Debian Configuration Management System (udeb)
 cdebconf-priority - Change debconf priority (udeb)
 cdebconf-text-udeb - Plain text frontend for Debian Configuration Management System (udeb)
 cdebconf-udeb - Debian Configuration Management System (C-implementation) (udeb)
 libdebconfclient0 - Debian Configuration Management System (C-implementation)
 libdebconfclient0-dev - Development files for cdebconf
 libdebconfclient0-udeb - Debian Configuration Management System (C-implementation) (udeb)
Closes: 381979 386752
 cdebconf (0.106) unstable; urgency=low
   [ Denis Barbier ]
   * Change select, multiselect and button colors for the newt interface
     when FRONTEND_BACKGROUND=dark, to improve text readability.
   [ Attilio Fiandrotti ]
   * Fix buffer overflow spotted by Aike Reyer <aike@users.sourceforge.net>
     in the GTK frontend. Closes: #386752.
   * GTK frontend: force DirectFB to reload keymap at every frontend_go() run.
     This will ensure that we have the correct keymap after the user selects
     one in kbd-chooser. This solution is a workaround until we can implement
     a reload triggered from kbd-chooser, which would be cleaner.
     Closes: #381979.
   [ Colin Watson ]
   * Refactor newt frontend to have a single common function to build the
     progress bar form, which redraws the progress bar when the
     progresscancel state changes (closes: https://launchpad.net/bugs/47733).
   * Allow Choices-C to be listed separately from Choices (etc.) in templates
     files. This lets you say "Choices: ${CHOICES-TRANS}" and "Choices-C:
     ${CHOICES}" to substitute reliably into translated and untranslated
     templates without having to ensure that ${CHOICES-TRANS} is translated
     to the same thing in every language.
   * X_LOADTEMPLATEFILE now takes an optional owner argument, passed to it by
   * Add debconf_x_save and debconf_info macros to debconfclient.h.
   * debconf-loadtemplate now tells debconf to save its databases immediately
     after loading templates files; this can make debugging easier under some
   [ Frans Pop ]
   * GTK frontend: don't print an extra ellipsis in the progress bar. Thanks
     to Jens Seidel for spotting this.
   [ Updated translations ]
   * Bengali (bn.po) by Mahay Alam Khan (মাহ� �লম �ান)
   * Catalan (ca.po) by Jordi Mallach
   * Czech (cs.po) by Miroslav Kure
   * Danish (da.po) by Claus Hindsgaul
   * German (de.po) by Jens Seidel
   * Esperanto (eo.po) by Serge Leblanc
   * Spanish (es.po) by Javier Fernández-Sanguino Peña
   * Basque (eu.po) by Piarres Beobide
   * Finnish (fi.po) by Tapio Lehtonen
   * French (fr.po) by Christian Perrier
   * Galician (gl.po) by Jacobo Tarrio
   * Hebrew (he.po) by Lior Kaplan
   * Hungarian (hu.po) by SZERVÃ?C Attila
   * Indonesian (id.po) by Arief S Fitrianto
   * Italian (it.po) by Giuseppe Sacco
   * Japanese (ja.po) by Kenshi Muto
   * Korean (ko.po) by Sunjae park
   * Kurdish (ku.po) by Erdal Ronahi
   * Lithuanian (lt.po) by KÄ?stutis BiliÅ«nas
   * Latvian (lv.po) by Aigars Mahinovs
   * Norwegian Bokmål (nb.po) by Bjørn Steensrud
   * Dutch (nl.po) by Bart Cornelis
   * Polish (pl.po) by Bartosz Fenski
   * Portuguese (Brazil) (pt_BR.po) by André Luís Lopes
   * Russian (ru.po) by Yuri Kozlov
   * Northern Sami (se.po) by Børre Gaup
   * Slovak (sk.po) by Peter Mann
   * Slovenian (sl.po) by Jure Ä?uhalev
   * Thai (th.po) by Theppitak Karoonboonyanan
   * Turkish (tr.po) by Recai OktaÅ?
   * Vietnamese (vi.po) by Clytie Siddall
   * Wolof (wo.po) by Mouhamadou Mamoune Mbacke
   * Simplified Chinese (zh_CN.po) by Carlos Z.F. Liu
 c6675ff2d81ddeeecc19107eb14075ac 1195 utils optional cdebconf_0.106.dsc
 a9c7b90eabbc2dc840564c419f61c74a 232980 utils optional cdebconf_0.106.tar.gz
 08c7a500c24ce60e9b417ca902031936 2754 debian-installer standard cdebconf-priority_0.106_all.udeb
 6dddb242b331c242606685775c72dc6d 143048 utils extra cdebconf_0.106_i386.deb
 853038b4c83517157ba4ed47cee66402 31326 libs optional libdebconfclient0_0.106_i386.deb
 c254e7db4b4697da757b09ff22068c4f 32714 libdevel optional libdebconfclient0-dev_0.106_i386.deb
 ad3a38d149565a179d0ddb2d20e0e762 58366 debian-installer standard cdebconf-udeb_0.106_i386.udeb
 5ac578b112f4550dc09c2bcac1f56a69 2968 debian-installer optional libdebconfclient0-udeb_0.106_i386.udeb
 98bd74807684d5d2117a1285bbded7e0 16602 debian-installer optional cdebconf-newt-udeb_0.106_i386.udeb
 2512932305eaea08a6b9d856ae84c285 18742 debian-installer optional cdebconf-text-udeb_0.106_i386.udeb
 799f6c931fc710c62b774470e607f4eb 22358 debian-installer optional cdebconf-gtk-udeb_0.106_i386.udeb
Package-Type: udeb

Version: GnuPG v1.4.1 (GNU/Linux)


--- End Message ---

Reply to: