[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#383896: marked as done (base-installer: Should use both extra package templates)

Your message dated Sat, 16 Sep 2006 03:17:03 -0700
with message-id <E1GOXEN-0005qw-Ry@spohr.debian.org>
and subject line Bug#383896: fixed in base-installer 1.67
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: base-installer
Version: 1.66
Tags: patch

When trying to install usplash before the kernel, to avoid running
update-initramfs more than once, I preseeded the package in the
base-installer/kernel/linux/extra-packages template, expecting this to
solve the issue.  It had no effect.

I discovered I had to use the
base-installer/kernel/linux/extra-packages-2.6 template instead.  I
expected base-installer/kernel/linux/extra-packages template to be
used for all kernels, whlie
base-installer/kernel/linux/extra-packages-2.6 used only for 2.6
kenrels, while in reallity, the values in
base-installer/kernel/linux/extra-packages are never used as the
db_get for base-installer/kernel/linux/extra-packages-2.6 will always
succeed.

I suggest rewriting the code to always use the content in
base-installer/kernel/linux/extra-packages, and use the kernel
specific version when the kernel version matches the variable.  Here
is a patch to implement it.

Index: debian/postinst
===================================================================
--- debian/postinst     (revisjon 40022)
+++ debian/postinst     (arbeidskopi)
@@ -708,12 +710,11 @@
                done

                # Install any extra (kernel related) packages
+               EXTRAS=
                if db_get "base-installer/kernel/linux/extra-packages-$target_kernel_major"; then
-                       EXTRAS="$RET"
-               elif db_get base-installer/kernel/linux/extra-packages; then
-                       EXTRAS="$RET"
-               else
-                       EXTRAS=
+                       EXTRAS="$EXTRAS $RET"
+               if db_get base-installer/kernel/linux/extra-packages; then
+                       EXTRAS="$EXTRAS $RET"
                fi
                for package in $EXTRAS; do
                        info "Installing $package."

--- End Message ---
--- Begin Message --- 
Source: base-installer
Source-Version: 1.67

We believe that the bug you reported is fixed in the latest version of
base-installer, which is due to be installed in the Debian FTP archive:

base-installer_1.67.dsc
  to pool/main/b/base-installer/base-installer_1.67.dsc
base-installer_1.67.tar.gz
  to pool/main/b/base-installer/base-installer_1.67.tar.gz
base-installer_1.67_i386.udeb
  to pool/main/b/base-installer/base-installer_1.67_i386.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 383896@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Frans Pop <fjp@debian.org> (supplier of updated base-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 16 Sep 2006 11:26:25 +0200
Source: base-installer
Binary: base-installer
Architecture: source i386
Version: 1.67
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Frans Pop <fjp@debian.org>
Description: 
 base-installer - Install the base system (udeb)
Closes: 383896
Changes: 
 base-installer (1.67) unstable; urgency=low
 .
   [ Petter Reinholdtsen ]
   * Always use template base-installer/kernel/linux/extra-packages, even if
     base-installer/kernel/linux/extra-packages-$kernelver exists.
     Closes: #383896.
 .
   [ dann frazier ]
   * Drop SMP detection on IA64. IA64 -smp flavours have been dropped.
     As of 2.6.17, all Debian IA64 kernels are SMP.
 .
   [ Colin Watson ]
   * Mark ${ERROR} in base-installer/debootstrap/fallback-error as
     untranslatable.
   * Suppress a spurious "dmsetup: not found" error.
 .
   [ Sven Luther ]
   * [powerpc] Added support for IBM Power5+ cpus.
 .
   [ Updated translations ]
   * Bengali (bn.po) by Mahay Alam Khan (মাহ� �লম �ান)
   * Czech (cs.po) by Miroslav Kure
   * Danish (da.po) by Claus Hindsgaul
   * German (de.po) by Jens Seidel
   * Spanish (es.po) by Javier Fernández-Sanguino Peña
   * Basque (eu.po) by Piarres Beobide
   * French (fr.po) by Christian Perrier
   * Galician (gl.po) by Jacobo Tarrio
   * Hebrew (he.po) by Lior Kaplan
   * Hungarian (hu.po) by SZERVÃ?C Attila
   * Indonesian (id.po) by Arief S Fitrianto
   * Italian (it.po) by Giuseppe Sacco
   * Japanese (ja.po) by Kenshi Muto
   * Korean (ko.po) by Sunjae park
   * Latvian (lv.po) by Aigars Mahinovs
   * Dutch (nl.po) by Bart Cornelis
   * Portuguese (pt.po) by Miguel Figueiredo
   * Portuguese (Brazil) (pt_BR.po) by André Luís Lopes
   * Romanian (ro.po) by Eddy PetriÅ?or
   * Russian (ru.po) by Yuri Kozlov
   * Northern Sami (se.po) by Børre Gaup
   * Slovak (sk.po) by Peter Mann
   * Swedish (sv.po) by Daniel Nylander
   * Thai (th.po) by Theppitak Karoonboonyanan
   * Tagalog (tl.po) by Eric Pareja
   * Turkish (tr.po) by Recai OktaÅ?
   * Vietnamese (vi.po) by Clytie Siddall
   * Wolof (wo.po) by Mouhamadou Mamoune Mbacke
Files: 
 688fb2e26d532f45909b161b0ba7d8d2 854 debian-installer required base-installer_1.67.dsc
 1faedd87582e6cf5deef55c579d99983 208117 debian-installer required base-installer_1.67.tar.gz
 6c3fbfecc107912531b4caa2750e7781 155212 debian-installer required base-installer_1.67_i386.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFFC8qfgm/Kwh6ICoQRAgLhAJ9SOJ22FZ35zkwy+Hp4cjCD3P8tBwCeOLVz
q+dgpmSFcXzCb0xup2OFPCQ=
=H1Mo
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: