[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r40335 - in trunk/packages/partman/partman-auto-lvm: . debian



On Wednesday 30 August 2006 18:58, David Härdeman wrote:
> Author: alphix-guest
> Date: Wed Aug 30 16:58:33 2006
> New Revision: 40335
> 
> Modified:
>    trunk/packages/partman/partman-auto-lvm/autopartition-lvm
>    trunk/packages/partman/partman-auto-lvm/debian/changelog
>    trunk/packages/partman/partman-auto-lvm/debian/partman-auto-lvm.templates
> 
> Log:
> Use the lvm wiping functionality from partman-auto >= 55
> 
> Modified: trunk/packages/partman/partman-auto-lvm/autopartition-lvm
> ==============================================================================
> --- trunk/packages/partman/partman-auto-lvm/autopartition-lvm   (original)
> +++ trunk/packages/partman/partman-auto-lvm/autopartition-lvm   Wed Aug 30 16:58:33 2006
> @@ -26,16 +26,10 @@
>         log-output -t update-dev update-dev
>  fi
>  
> -# Check if the device already contains any physical volumes
> -realdev=$(mapdevfs "$(cat $dev/device)")
> -if pv_on_device "$realdev"; then
> -       bail_out pv_on_device
> -fi
> +wipe_disk || exit $?
>  
>  choose_recipe "$free_size" lvm || exit $?
>  
> -wipe_disk || exit $?
> -

What is the reason wipe_disk was moved before the recipe selection?
Does it not make more sense to keep it after so the disk is not wiped if
you choose to abort (Go Back) during recipe selection?

Attachment: pgp67VvVlHFdq.pgp
Description: PGP signature


Reply to: